Browse Source

Merge "Fix backup node lookup"

changes/98/745598/4
Zuul 1 week ago
committed by Gerrit Code Review
parent
commit
42df6c174f
3 changed files with 11 additions and 2 deletions
  1. +1
    -1
      ironic_python_agent/hardware.py
  2. +1
    -1
      ironic_python_agent/tests/unit/test_hardware.py
  3. +9
    -0
      releasenotes/notes/fix-auxillarly-node-lookup-argument-83d3f717c039e454.yaml

+ 1
- 1
ironic_python_agent/hardware.py View File

@@ -498,7 +498,7 @@ def update_cached_node():
hardware_info=list_hardware_info(use_cache=True),
timeout=API_LOOKUP_TIMEOUT,
starting_interval=API_LOOKUP_INTERVAL,
uuid=uuid)
node_uuid=uuid)
cache_node(content['node'])
return content['node']
except Exception as exc:


+ 1
- 1
ironic_python_agent/tests/unit/test_hardware.py View File

@@ -4533,7 +4533,7 @@ class TestAPIClientSaveAndUse(base.IronicAgentTest):
hardware_info=mock.ANY,
timeout=1,
starting_interval=2,
uuid='node1')
node_uuid='node1')
self.assertEqual(updated_node, hardware.NODE)
calls = [mock.call('list_hardware_info'),
mock.call('wait_for_disks')]


+ 9
- 0
releasenotes/notes/fix-auxillarly-node-lookup-argument-83d3f717c039e454.yaml View File

@@ -0,0 +1,9 @@
---
fixes:
- |
Fixes a minor incorrect keyword argument that was
matching between the method caller and the unit test but
not the actual method, unit test, and caller. This was
a non-fatal issue, and should now permit the agent to
attempt to lookup the node one last time before deploying
the instance image to pick-up a root device hint.

Loading…
Cancel
Save