openstack/ironic-python-agent
Code Issues Proposed changes

Merge "Trivial: minor fixes in error messages"

Browse Source
This commit is contained in:
Zuul 2021-09-09 01:02:18 +00:00 committed by Gerrit Code Review
commit 47a7fb5ff7
3 changed files with 3 additions and 3 deletions
ironic_python_agent/extensions
clean.pydeploy.pystandby.py

2
ironic_python_agent/extensions/clean.py

@ -74,7 +74,7 @@ class CleanExtension(base.BaseAgentExtension):
try: try:
result = hardware.dispatch_to_managers(step['step'], node, ports) result = hardware.dispatch_to_managers(step['step'], node, ports)
except Exception as e: except Exception as e:
msg = ('Error performing clean_step %(step)s: %(err)s' % msg = ('Error performing clean step %(step)s: %(err)s' %
{'step': step['step'], 'err': e}) {'step': step['step'], 'err': e})
LOG.exception(msg) LOG.exception(msg)
raise errors.CleaningError(msg) raise errors.CleaningError(msg)

2
ironic_python_agent/extensions/deploy.py

@ -76,7 +76,7 @@ class DeployExtension(base.BaseAgentExtension):
result = hardware.dispatch_to_managers(step['step'], node, ports, result = hardware.dispatch_to_managers(step['step'], node, ports,
**kwargs) **kwargs)
except Exception as e: except Exception as e:
msg = ('Error performing deploy_step %(step)s: %(err)s' % msg = ('Error performing deploy step %(step)s: %(err)s' %
{'step': step['step'], 'err': e}) {'step': step['step'], 'err': e})
LOG.exception(msg) LOG.exception(msg)
raise errors.DeploymentError(msg) raise errors.DeploymentError(msg)

2
ironic_python_agent/extensions/standby.py

@ -523,7 +523,7 @@ def _validate_partitioning(device):
except (processutils.UnknownArgumentError, except (processutils.UnknownArgumentError,
processutils.ProcessExecutionError, OSError) as e: processutils.ProcessExecutionError, OSError) as e:
msg = ("Unable to find a valid partition table on the disk after " msg = ("Unable to find a valid partition table on the disk after "
"writing the image. Error {}".format(e)) f"writing the image. The image may be corrupted. Error: {e}")
raise exception.InstanceDeployFailure(msg) raise exception.InstanceDeployFailure(msg)
# Check if there is at least one partition in the partition table after # Check if there is at least one partition in the partition table after