openstack/ironic-python-agent
Code Issues Proposed changes

Replace dict.get(key) with dict[key] in tests

Browse Source 
This replaces dict.get(key) with dict[key] in the unit tests,
since we should be explicit about whether we expect the key to
exist or not. (These are tests, after all.)

Change-Id: Ide98ceba325214e55cab2063d9ace150d63f9617
Closes-Bug: #1590808
This commit is contained in:
Ruby Loo 2016-06-23 17:41:23 -04:00
parent 0c5a1cfd56
commit 50ddb894b4
2 changed files with 4 additions and 4 deletions
ironic_python_agent/tests/unit
extensions
test_standby.py
test_hardware.py

2
ironic_python_agent/tests/unit/extensions/test_standby.py

@ -190,7 +190,7 @@ class TestStandbyExtension(test_base.BaseTestCase):
swap_mb = image_info['swap_mb']
ephemeral_mb = image_info['ephemeral_mb']
ephemeral_format = image_info['ephemeral_format']
node_uuid = image_info.get('node_uuid')
node_uuid = image_info['node_uuid']
pr_ep = image_info['preserve_ephemeral']
configdrive = image_info['configdrive']
boot_mode = image_info['deploy_boot_mode']

6
ironic_python_agent/tests/unit/test_hardware.py

@ -851,7 +851,7 @@ class TestGenericHardwareManager(test_base.BaseTestCase):
hdparm_output = create_hdparm_info(
supported=False, enabled=False, frozen=False, enhanced_erase=False)
info = self.node.get('driver_internal_info')
info = self.node['driver_internal_info']
info['agent_erase_devices_iterations'] = 2
info['agent_erase_devices_zeroize'] = False
@ -874,7 +874,7 @@ class TestGenericHardwareManager(test_base.BaseTestCase):
hdparm_output = create_hdparm_info(
supported=False, enabled=False, frozen=False, enhanced_erase=False)
info = self.node.get('driver_internal_info')
info = self.node['driver_internal_info']
info['agent_erase_devices_iterations'] = 0
info['agent_erase_devices_zeroize'] = False
@ -1124,7 +1124,7 @@ class TestGenericHardwareManager(test_base.BaseTestCase):
def test_erase_block_device_ata_failed_continued(
self, mocked_execute, mock_shred):
info = self.node.get('driver_internal_info')
info = self.node['driver_internal_info']
info['agent_continue_if_ata_erase_failed'] = True
hdparm_output_before = create_hdparm_info(