Do not serialize command_params
The command params can be huge when configdrive is used. There is no point in sending them back, Ironic does not use them anyhow. Story: #2008904 Task: #42479 Change-Id: I6e3db5db2042ca3fb5dafacfacf036fd7fc2fc4c
This commit is contained in:
parent
6fb4cec7aa
commit
51aa31070a
@ -42,7 +42,7 @@ class AgentCommandStatus(object):
|
|||||||
class BaseCommandResult(encoding.SerializableComparable):
|
class BaseCommandResult(encoding.SerializableComparable):
|
||||||
"""Base class for command result."""
|
"""Base class for command result."""
|
||||||
|
|
||||||
serializable_fields = ('id', 'command_name', 'command_params',
|
serializable_fields = ('id', 'command_name',
|
||||||
'command_status', 'command_error', 'command_result')
|
'command_status', 'command_error', 'command_result')
|
||||||
|
|
||||||
def __init__(self, command_name, command_params):
|
def __init__(self, command_name, command_params):
|
||||||
|
@ -742,9 +742,6 @@ class TestBaseAgent(ironic_agent_base.IronicAgentTest):
|
|||||||
expected_result = {
|
expected_result = {
|
||||||
'id': result.id,
|
'id': result.id,
|
||||||
'command_name': 'foo_command',
|
'command_name': 'foo_command',
|
||||||
'command_params': {
|
|
||||||
'fail': False,
|
|
||||||
},
|
|
||||||
'command_status': 'RUNNING',
|
'command_status': 'RUNNING',
|
||||||
'command_result': None,
|
'command_result': None,
|
||||||
'command_error': None,
|
'command_error': None,
|
||||||
@ -766,9 +763,6 @@ class TestBaseAgent(ironic_agent_base.IronicAgentTest):
|
|||||||
expected_result = {
|
expected_result = {
|
||||||
'id': result.id,
|
'id': result.id,
|
||||||
'command_name': 'foo_command',
|
'command_name': 'foo_command',
|
||||||
'command_params': {
|
|
||||||
'fail': True,
|
|
||||||
},
|
|
||||||
'command_status': 'RUNNING',
|
'command_status': 'RUNNING',
|
||||||
'command_result': None,
|
'command_result': None,
|
||||||
'command_error': None,
|
'command_error': None,
|
||||||
|
5
releasenotes/notes/command_params-869fa547b5be2236.yaml
Normal file
5
releasenotes/notes/command_params-869fa547b5be2236.yaml
Normal file
@ -0,0 +1,5 @@
|
|||||||
|
---
|
||||||
|
fixes:
|
||||||
|
- |
|
||||||
|
The command params no longer appear in the command results. See `story
|
||||||
|
2008904 <https://storyboard.openstack.org/#!/story/2008904>`_ for details.
|
Loading…
Reference in New Issue
Block a user