Merge "Add mlnx deploy_step entry to enable deploy time firmware"

ironic_python_agent/hardware_managers/mlnx.py

@@ -163,8 +163,9 @@ class MellanoxDeviceHardwareManager(hardware.HardwareManager):
         # NOTE(TheJulia): Since these steps can be run upon service, why not
         return self.get_clean_steps(node, ports)
 
-    # TODO(TheJulia): Should there be a get_deploy_steps handler here? Since
-    # flashing firmware on deploy is a valid case.
+    def get_deploy_steps(self, node, ports):
+        """Alias wrapper for method get_clean_steps."""
+        return self.get_clean_steps(node, ports)
 
     def update_nvidia_nic_firmware_image(self, node, ports, images):
         nvidia_fw_update.update_nvidia_nic_firmware_image(images)

ironic_python_agent/tests/unit/hardware_managers/test_mlnx.py

@@ -77,6 +77,10 @@ class MlnxHardwareManager(base.IronicAgentTest):
              'step': 'update_nvidia_nic_firmware_settings'}]
         self.assertEqual(self.hardware.get_clean_steps(self.node, []),
                          expected_clean_steps)
+        self.assertEqual(self.hardware.get_service_steps(self.node, []),
+                         expected_clean_steps)
+        self.assertEqual(self.hardware.get_deploy_steps(self.node, []),
+                         expected_clean_steps)
 
     @mock.patch.object(os, 'listdir', autospec=True)
     @mock.patch.object(hardware, '_get_device_info', autospec=True)

releasenotes/notes/mlnx-steps-now-available-for-deploy-4a4226ffaae888f3.yaml

@@ -0,0 +1,6 @@
+---
+features:
+  - |
+    The Nvidia Mellanox "clean steps" to facilitate firmware updates of
+    their network devices, are now available as deploy steps and service
+    steps as well.