openstack/ironic-python-agent
Code Issues Proposed changes

Mock get_node_boot_mode in software RAID unit tests

Browse Source 
This function checks for /sys/firmware/efi. Some tests do not mock
isdir, so they fail on UEFI machines.

Change-Id: I088218ddb88717ac07669d0b97c6cd50208ede8c
This commit is contained in:
Dmitry Tantsur
2020-04-20 16:41:28 +02:00
parent 6035771676
commit 896f389d5c
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
ironic_python_agent/tests/unit/test_hardware.py
View File

@@ -2856,6 +2856,7 @@ class TestGenericHardwareManager(base.IronicAgentTest):
mock.call(x) for x in ['/dev/sda', '/dev/sdb']
])
@mock.patch.object(utils, 'get_node_boot_mode', lambda node: 'bios')
@mock.patch.object(disk_utils, 'list_partitions', autospec=True,
return_value=[])
@mock.patch.object(utils, 'execute', autospec=True)
@@ -2938,6 +2939,7 @@ class TestGenericHardwareManager(base.IronicAgentTest):
'/dev/sda2', '/dev/sdb2', '/dev/sdc2')])
self.assertEqual(raid_config, result)
@mock.patch.object(utils, 'get_node_boot_mode', lambda node: 'bios')
@mock.patch.object(disk_utils, 'list_partitions', autospec=True,
return_value=[])
@mock.patch.object(utils, 'execute', autospec=True)
@@ -3305,6 +3307,7 @@ class TestGenericHardwareManager(base.IronicAgentTest):
'/dev/sda2', '/dev/sdb2')])
self.assertEqual(raid_config, result)
@mock.patch.object(utils, 'get_node_boot_mode', lambda node: 'bios')
@mock.patch.object(disk_utils, 'list_partitions', autospec=True,
return_value=[])
@mock.patch.object(utils, 'execute', autospec=True)