From 2fcf35e56d578d98d77ffc97b6441f83548d7704 Mon Sep 17 00:00:00 2001 From: Dmitry Tantsur Date: Fri, 11 Jun 2021 16:04:59 +0200 Subject: [PATCH] Reduce logging verbosity when collecting logs It's not uncommon that some commands fail when collecting logs. We already log all failures in utils.execute, no need to duplicate them with a non-fatal ERROR logging. Change-Id: If151b3a3be979bd2b3ce01030e5d6242ad74eaa3 --- ironic_python_agent/utils.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ironic_python_agent/utils.py b/ironic_python_agent/utils.py index 03de236c6..b5d0533a1 100644 --- a/ironic_python_agent/utils.py +++ b/ironic_python_agent/utils.py @@ -478,7 +478,6 @@ def get_command_output(command): except (processutils.ProcessExecutionError, OSError) as e: error_msg = ('Failed to get the output of the command "%(command)s". ' 'Error: %(error)s' % {'command': command, 'error': e}) - LOG.error(error_msg) raise errors.CommandExecutionError(error_msg) return io.BytesIO(out) @@ -547,7 +546,7 @@ def collect_system_logs(journald_max_lines=None): try: io_dict[file_name] = get_command_output(command) except errors.CommandExecutionError: - pass + LOG.debug('Collecting logs from command %s has failed', command) io_dict = {} file_list = []