openstack
/
ironic-python-agent
Code Issues Proposed changes

Update patch set 3 

Patch Set 3: Code-Review-1

(1 comment)

Patch-set: 3
Reviewer: Gerrit User 4571 <4571@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 1b79ab916056fb9291fc662ff3186253be0922e3
This commit is contained in:
Gerrit User 4571 2023-04-10 21:36:42 +00:00 committed by Gerrit Code Review
parent 2ed40079d8
commit 8f11e0fa9a
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
d767d0be8400d21dc2480c5b8d922e2a3a7c5eca Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "0eed819b_5738e469",
"filename": "ironic_python_agent/tests/unit/test_hardware.py",
"patchSetId": 3
},
"lineNbr": 702,
"author": {
"id": 4571
},
"writtenOn": "2023-04-10T21:36:42Z",
"side": 1,
"message": "I think these are missing the 2 ip link calls in netutils._add_vlan_interface, the StopIteration is not being logged as expected.",
"revId": "d767d0be8400d21dc2480c5b8d922e2a3a7c5eca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}