openstack
/
ironic-python-agent
Code Issues Proposed changes

Update patch set 5 

Patch Set 5: Code-Review-1

(2 comments)

Hi! 2 nits about variable naming in tests, otherwise lgtm

Patch-set: 5
Label: Code-Review=-1
This commit is contained in:
Gerrit User 10239 2014-06-16 14:31:54 +00:00 committed by Gerrit Code Review
parent 9e95d8a3cb
commit 94d9385000
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
33e8c0dab2dea307a8314c8c366b0c91f9c7c671 Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"key": {
"uuid": "1ae5cdf2_6a2ad091",
"filename": "ironic_python_agent/tests/hardware.py",
"patchSetId": 5
},
"lineNbr": 150,
"author": {
"id": 10239
},
"writtenOn": "2014-06-16T14:31:54Z",
"side": 1,
"message": "MockedExtensionManager is a variable and should be named lowercase+underscore (despite it contains mock for constructor)",
"revId": "33e8c0dab2dea307a8314c8c366b0c91f9c7c671",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1ae5cdf2_e571b3a9",
"filename": "ironic_python_agent/tests/hardware.py",
"patchSetId": 5
},
"lineNbr": 154,
"author": {
"id": 10239
},
"writtenOn": "2014-06-16T14:31:54Z",
"side": 1,
"message": "Variable name confuses me a bit: it\u0027s not a manager, it\u0027s an extension, no?",
"revId": "33e8c0dab2dea307a8314c8c366b0c91f9c7c671",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}