openstack
/
ironic-python-agent
Code Issues Proposed changes

Remove unused version parameter in version header function 

The logic to determine the version when getting the ironic version
header is not influenced by the version parameter passed to the
function.

Change-Id: Ie52a82bf71a2277cea11fd2dedfd9c1e0001d95f
This commit is contained in:
Riccardo Pittau 2020-04-08 12:17:41 +02:00
parent bdc5e9448d
commit 9ac6040110
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ironic_python_agent/ironic_api_client.py
View File

@ -78,7 +78,7 @@ class APIClient(object):
cert=cert,
**kwargs)
def _get_ironic_api_version_header(self, version=MIN_IRONIC_VERSION):
def _get_ironic_api_version_header(self):
# TODO(TheJulia): It would be great to improve version handling
# logic, but we need to ship a newer version if we can.
ironic_version = "%d.%d" % self._get_ironic_api_version()
@ -117,10 +117,8 @@ class APIClient(object):
if api_ver >= AGENT_VERSION_IRONIC_VERSION:
data['agent_version'] = version.version_info.release_string()
headers = self._get_ironic_api_version_header(
AGENT_VERSION_IRONIC_VERSION)
else:
headers = self._get_ironic_api_version_header()
headers = self._get_ironic_api_version_header()
try:
response = self._request('POST', path, data=data, headers=headers)