From b2f0539d9ca223e5186d05bd7f4a86a162bc377d Mon Sep 17 00:00:00 2001 From: Dongcan Ye Date: Mon, 29 Apr 2019 09:29:18 +0000 Subject: [PATCH] Add more channel number for detecting BMC IP address IPMI SPEC[1] assignment channel number 1-11 for vendors implementation(We an search "Channel Numbers" in section 6.3). We met an baremetal product, like H3C, use number 8 as LAN channel. Current code limit channel number to 1~7, I think this can increase to 1~11. [1] https://www.intel.com/content/dam/www/public/us/en/documents/product-briefs/ipmi-second-gen-interface-spec-v2-rev1-1.pdf Change-Id: I63a6ff91d702b990ef09da13e6e2e269e7274cce Task: 30654 Story: 2005528 (cherry picked from commit 66d3c8e453a58c01740581079045e9b4368c4bde) --- ironic_python_agent/hardware.py | 7 ++++--- .../notes/add-more-lan-channels-8f5197ed5f057c25.yaml | 7 +++++++ 2 files changed, 11 insertions(+), 3 deletions(-) create mode 100644 releasenotes/notes/add-more-lan-channels-8f5197ed5f057c25.yaml diff --git a/ironic_python_agent/hardware.py b/ironic_python_agent/hardware.py index 92a9db543..e3cea8441 100644 --- a/ironic_python_agent/hardware.py +++ b/ironic_python_agent/hardware.py @@ -1108,9 +1108,10 @@ class GenericHardwareManager(HardwareManager): utils.try_execute('modprobe', 'ipmi_si') try: - # From all the channels 0-15, only 1-7 can be assigned to different - # types of communication media and protocols and effectively used - for channel in range(1, 8): + # From all the channels 0-15, only 1-11 can be assigned to + # different types of communication media and protocols and + # effectively used + for channel in range(1, 12): out, e = utils.execute( "ipmitool lan print {} | awk '/IP Address[ \\t]*:/" " {{print $4}}'".format(channel), shell=True) diff --git a/releasenotes/notes/add-more-lan-channels-8f5197ed5f057c25.yaml b/releasenotes/notes/add-more-lan-channels-8f5197ed5f057c25.yaml new file mode 100644 index 000000000..b659e3860 --- /dev/null +++ b/releasenotes/notes/add-more-lan-channels-8f5197ed5f057c25.yaml @@ -0,0 +1,7 @@ +--- +fixes: + - | + From IPMI specification v2.0, channel number 1-Bh(1-11) can + be used for various types of communications channels. + The respectively available channels depend on the specific + IPMI implementation for a specific server system.