From 814b60def3457751f5c4eed9befea2f9f0ec27cd Mon Sep 17 00:00:00 2001 From: Luong Anh Tuan Date: Mon, 29 Aug 2016 10:07:14 +0700 Subject: [PATCH] Using assertIsNone() is preferred over assertEqual() Following OpenStack Style Guidelines[1]: http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises [H203] Unit test assertions tend to give better messages for more specific assertions. As a result, assertIsNone(...) is preferred over assertEqual(None, ...) Change-Id: I53c6d6d3e53d9fac38c50faf065c131d3aa55224 --- ironic_python_agent/tests/unit/test_hardware.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ironic_python_agent/tests/unit/test_hardware.py b/ironic_python_agent/tests/unit/test_hardware.py index d18a838de..a429c7589 100644 --- a/ironic_python_agent/tests/unit/test_hardware.py +++ b/ironic_python_agent/tests/unit/test_hardware.py @@ -328,7 +328,7 @@ class TestGenericHardwareManager(test_base.BaseTestCase): self.assertEqual('eth0', interfaces[0].name) self.assertEqual('00:0c:29:8c:11:b1', interfaces[0].mac_address) self.assertEqual('192.168.1.2', interfaces[0].ipv4_address) - self.assertEqual(None, interfaces[0].lldp) + self.assertIsNone(interfaces[0].lldp) self.assertTrue(interfaces[0].has_carrier) @mock.patch('ironic_python_agent.netutils.get_lldp_info') @@ -396,7 +396,7 @@ class TestGenericHardwareManager(test_base.BaseTestCase): self.assertEqual('eth0', interfaces[0].name) self.assertEqual('00:0c:29:8c:11:b1', interfaces[0].mac_address) self.assertEqual('192.168.1.2', interfaces[0].ipv4_address) - self.assertEqual(None, interfaces[0].lldp) + self.assertIsNone(interfaces[0].lldp) self.assertTrue(interfaces[0].has_carrier) @mock.patch('netifaces.ifaddresses')