openstack
/
ironic-python-agent
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review-1

(3 comments)

Patch-set: 1
Reviewer: Gerrit User 10239 <10239@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 9587a2bb057f3a5d98f9652d018999ba5140ad15
This commit is contained in:
Gerrit User 10239 2023-04-12 10:45:33 +00:00 committed by Gerrit Code Review
parent 54939b9970
commit af5cc595b1
1 changed files with 55 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
32a36a752c032f1bd9bc0b11ca194f51c2cef281 Normal file
View File

@ -0,0 +1,55 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "d264ebc3_b504cb80",
"filename": "ironic_python_agent/hardware_managers/nvidia/nvidia_fw_update.py",
"patchSetId": 1
},
"lineNbr": 419,
"author": {
"id": 10239
},
"writtenOn": "2023-04-12T10:45:33Z",
"side": 1,
"message": "Let\u0027s make this and the other instances configurable. It won\u0027t take much for someone with an unusual network setup to come complain...",
"revId": "32a36a752c032f1bd9bc0b11ca194f51c2cef281",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e0f44d56_6a514c8a",
"filename": "ironic_python_agent/hardware_managers/nvidia/nvidia_fw_update.py",
"patchSetId": 1
},
"lineNbr": 445,
"author": {
"id": 10239
},
"writtenOn": "2023-04-12T10:45:33Z",
"side": 1,
"message": "Could you fix this separately? It\u0027s an important enough fix to be split from the bandit one and backported.\n\nOn top of that, the error message below should be fixed and we should make sure that the download process respects the TLS configuration.",
"revId": "32a36a752c032f1bd9bc0b11ca194f51c2cef281",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "def55759_93717f76",
"filename": "zuul.d/project.yaml",
"patchSetId": 1
},
"lineNbr": 12,
"author": {
"id": 10239
},
"writtenOn": "2023-04-12T10:45:33Z",
"side": 1,
"message": "Voting jobs must be added to the gate",
"revId": "32a36a752c032f1bd9bc0b11ca194f51c2cef281",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}