openstack/ironic-python-agent
Code Issues Proposed changes

Merge "switch from 'not is' to 'is not' for pep8"

Browse Source
This commit is contained in:
Zuul
2025-01-29 17:15:56 +00:00
committed by Gerrit Code Review
parent 5333525411 c289ac0f18
commit b0623f0ac9
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ironic_python_agent/hardware.py
View File

@@ -2803,7 +2803,7 @@ class GenericHardwareManager(HardwareManager):
match_patterns = DEFAULT_CLEAN_UEFI_NVRAM_MATCH_PATTERNS match_patterns = DEFAULT_CLEAN_UEFI_NVRAM_MATCH_PATTERNS
validation_error = ('The match_patterns must be a list of strings: ' validation_error = ('The match_patterns must be a list of strings: '
'{}').format(match_patterns) '{}').format(match_patterns)
if not type(match_patterns) is list: if type(match_patterns) is not list:
raise errors.InvalidCommandParamsError(validation_error) raise errors.InvalidCommandParamsError(validation_error)
patterns = [] patterns = []
for item in match_patterns: for item in match_patterns:

4
ironic_python_agent/hardware_managers/nvidia/nvidia_fw_update.py
View File

@@ -906,7 +906,7 @@ def update_nvidia_nic_firmware_image(images):
:param images: list of images :param images: list of images
:raises: InvalidFirmwareImageConfig :raises: InvalidFirmwareImageConfig
""" """
if not type(images) is list: if type(images) is not list:
err = 'The images must be a list of images, %s' % images err = 'The images must be a list of images, %s' % images
raise InvalidFirmwareImageConfig(details=err) raise InvalidFirmwareImageConfig(details=err)
check_prereq() check_prereq()
@@ -924,7 +924,7 @@ def update_nvidia_nic_firmware_settings(settings):
:param settings: list of settings :param settings: list of settings
:raises: InvalidFirmwareSettingsConfig :raises: InvalidFirmwareSettingsConfig
""" """
if not type(settings) is list: if type(settings) is not list:
err = 'The settings must be list of settings, %s' % settings err = 'The settings must be list of settings, %s' % settings
raise InvalidFirmwareSettingsConfig(details=err) raise InvalidFirmwareSettingsConfig(details=err)
check_prereq() check_prereq()