openstack
/
ironic-python-agent
Code Issues Proposed changes

Update patch set 2 

Patch Set 2: Code-Review-1

(2 comments)

Patch-set: 2
Reviewer: Gerrit User 10342 <10342@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, afc12583a5510019f5fd9bb0bf485bcfbadc306e
This commit is contained in:
Gerrit User 10342 2023-04-19 18:38:09 +00:00 committed by Gerrit Code Review
parent 95392aa42a
commit c201b7121e
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
a55f3b8e18f8ab7ae1d3f5e30aa33f7932f75d04 Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "867ee9d9_da0356a9",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 10342
},
"writtenOn": "2023-04-19T18:38:09Z",
"side": 1,
"message": "LGTM outside of the one question. Should we get Ade Lee to review this, too?",
"revId": "a55f3b8e18f8ab7ae1d3f5e30aa33f7932f75d04",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "47691ab2_68c64287",
"filename": "ironic_python_agent/extensions/standby.py",
"patchSetId": 2
},
"lineNbr": 296,
"author": {
"id": 10342
},
"writtenOn": "2023-04-19T18:38:09Z",
"side": 1,
"message": "Is it intentional that this isn\u0027t adding usedforsecurity\u003dFalse? https://docs.python.org/3/library/hashlib.html#hashlib.new",
"revId": "a55f3b8e18f8ab7ae1d3f5e30aa33f7932f75d04",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}