openstack/ironic-python-agent
Code Issues Proposed changes

Merge "Provide usable __repr__ for serializable objects"

Browse Source
This commit is contained in:
Zuul
2025-07-22 01:26:55 +00:00
committed by Gerrit Code Review
parent f693a10003 ddeed6fa9e
commit c2c72eef97
2 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
ironic_python_agent/encoding.py
View File

@@ -24,6 +24,11 @@ class Serializable(object):
"""Turn this object into a dict.""" """Turn this object into a dict."""
return dict((f, getattr(self, f)) for f in self.serializable_fields) return dict((f, getattr(self, f)) for f in self.serializable_fields)
def __repr__(self):
fields = " ".join(f"{f}=" + repr(getattr(self, f))
for f in self.serializable_fields)
return f"<{self.__class__.__name__} {fields}>"
class SerializableComparable(Serializable): class SerializableComparable(Serializable):
"""A Serializable class which supports some comparison operators """A Serializable class which supports some comparison operators

2
ironic_python_agent/tests/unit/test_encoding.py
View File

@@ -43,6 +43,8 @@ class TestSerializable(base.IronicAgentTest):
expected = {'jack': 'hello', 'jill': 'world'} expected = {'jack': 'hello', 'jill': 'world'}
obj = SerializableTesting('hello', 'world') obj = SerializableTesting('hello', 'world')
self.assertEqual(expected, obj.serialize()) self.assertEqual(expected, obj.serialize())
self.assertEqual(
"<SerializableTesting jack='hello' jill='world'>", repr(obj))
class TestSerializableComparable(base.IronicAgentTest): class TestSerializableComparable(base.IronicAgentTest):