From c9d00d92788a1c70767e6bedadfae6cddec34ca8 Mon Sep 17 00:00:00 2001 From: Mark Goddard Date: Fri, 24 Jun 2022 16:47:18 +0100 Subject: [PATCH] Warn when smartctl not found Currently, if smartctl is not found by IPA, it will silently skip ATA secure erase and proceed to shred (if enabled). This is supposedly for backwards compatibility, but is quite hard to diagnose. This change adds a warning message to make it more obvious what is happening. TrivialFix Change-Id: I03a381e99de79f201ec7e9a388777c3d48457e93 (cherry picked from commit b68fa6b2e13774dbde5d0b81f6bf0b0095536aa4) --- ironic_python_agent/hardware.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ironic_python_agent/hardware.py b/ironic_python_agent/hardware.py index 3bdebefec..7e7354235 100644 --- a/ironic_python_agent/hardware.py +++ b/ironic_python_agent/hardware.py @@ -1688,10 +1688,11 @@ class GenericHardwareManager(HardwareManager): 'ATA commands via the `smartctl` utility with device ' '%s do not succeed.', block_device.name) return False - except OSError: + except OSError as e: # Processutils can raise OSError if a path is not found, # and it is okay that we tollerate that since it was the # prior behavior. + LOG.warning('Unable to execute `smartctl` utility: %s', e) return True def _ata_erase(self, block_device):