openstack
/
ironic-python-agent
Code Issues Proposed changes

Update patch set 5 

Patch Set 5:

(1 comment)

Patch-set: 5
Attention: {"person_ident":"Gerrit User 10342 \u003c10342@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_11655\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 11655 \u003c11655@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_11655\u003e replied on the change"}
This commit is contained in:
Gerrit User 11655 2023-04-25 00:20:40 +00:00 committed by Gerrit Code Review
parent 380be888c4
commit d0e5bae923
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
76accfb880474445a5dcb07825889123b3dd0237
View File

@ -16,6 +16,24 @@
"message": "Hmm. If we are ignoring errors, are we guaranteed cmd_output is not-None here?",
"revId": "76accfb880474445a5dcb07825889123b3dd0237",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d22a7258_02a14ca9",
"filename": "ironic_python_agent/efi_utils.py",
"patchSetId": 5
},
"lineNbr": 286,
"author": {
"id": 11655
},
"writtenOn": "2023-04-25T00:20:40Z",
"side": 1,
"message": "We have a test which would otherwise result in a decoding error.\n\nhttps://review.opendev.org/c/openstack/ironic-python-agent/+/879897/5/ironic_python_agent/tests/unit/test_efi_utils.py#234",
"parentUuid": "1b934400_17f20361",
"revId": "76accfb880474445a5dcb07825889123b3dd0237",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}