Update patch set 4

Patch Set 4: Code-Review-1

(7 comments)

Patch-set: 4
Reviewer: Gerrit User 10239 <10239@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 8db379a394cbe3b3b0d35ad046fb89621bf4a03f
This commit is contained in:
Gerrit User 10239 2023-04-12 10:43:13 +00:00 committed by Gerrit Code Review
parent e4f9ce195a
commit d45eeb0176
1 changed files with 123 additions and 0 deletions

View File

@ -0,0 +1,123 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "26e4eda9_3855f30f",
"filename": "ironic_python_agent/efi_utils.py",
"patchSetId": 4
},
"lineNbr": 278,
"author": {
"id": 10239
},
"writtenOn": "2023-04-12T10:43:13Z",
"side": 1,
"message": "nit: s/python3//",
"revId": "0334265c80b0bbd73d45775db01819d7a998ba4f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "2e5e0daf_8640d7ed",
"filename": "ironic_python_agent/efi_utils.py",
"patchSetId": 4
},
"lineNbr": 280,
"author": {
"id": 10239
},
"writtenOn": "2023-04-12T10:43:13Z",
"side": 1,
"message": "what\u0027s the condition of this being false? any bytes object has a decode()",
"revId": "0334265c80b0bbd73d45775db01819d7a998ba4f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "964d7b64_c296cf13",
"filename": "ironic_python_agent/efi_utils.py",
"patchSetId": 4
},
"lineNbr": 289,
"author": {
"id": 10239
},
"writtenOn": "2023-04-12T10:43:13Z",
"side": 1,
"message": "Fortunately, this branch is never reached, because str(bytes) does not do what you probably expect (it\u0027s a string representation of a python object, e.g.\n\n \u003e\u003e\u003e print(str(b\u0027foo\u0027))\n b\u0027foo\u0027\n\n).",
"revId": "0334265c80b0bbd73d45775db01819d7a998ba4f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "c4e9c942_364be708",
"filename": "ironic_python_agent/extensions/image.py",
"patchSetId": 4
},
"lineNbr": 578,
"author": {
"id": 10239
},
"writtenOn": "2023-04-12T10:43:13Z",
"side": 1,
"message": "This is excessive, the --version command does not output anything from the nvram",
"revId": "0334265c80b0bbd73d45775db01819d7a998ba4f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "d6464a21_b519282a",
"filename": "ironic_python_agent/tests/unit/extensions/test_image.py",
"patchSetId": 4
},
"lineNbr": 232,
"author": {
"id": 10239
},
"writtenOn": "2023-04-12T10:43:13Z",
"side": 1,
"message": "You need to update this to return binaries. Otherwise, you\u0027re hitting the weird case of not having decode()",
"revId": "0334265c80b0bbd73d45775db01819d7a998ba4f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "18725039_688620f2",
"filename": "releasenotes/notes/fixes-efibootmgr-character-encoding-19e531ba694824c1.yaml",
"patchSetId": 4
},
"lineNbr": 7,
"author": {
"id": 10239
},
"writtenOn": "2023-04-12T10:43:13Z",
"side": 1,
"message": "nit: I wonder if it\u0027s actually true. If the encoding is really REALLY unexpected, decoding it as UTF-16 may provide unusual results even with errors\u003d\u0027ignore\u0027.",
"revId": "0334265c80b0bbd73d45775db01819d7a998ba4f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "cdec4833_9fde9215",
"filename": "releasenotes/notes/fixes-efibootmgr-character-encoding-19e531ba694824c1.yaml",
"patchSetId": 4
},
"lineNbr": 8,
"author": {
"id": 10239
},
"writtenOn": "2023-04-12T10:43:13Z",
"side": 1,
"message": "nit: douple dots",
"revId": "0334265c80b0bbd73d45775db01819d7a998ba4f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}