openstack
/
ironic-python-agent
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review+1

(2 comments)

Patch-set: 1
Reviewer: Gerrit User 10342 <10342@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1, 57ed280580c3539afa5bea7695f84fe0d07cb0a4
This commit is contained in:
Gerrit User 10342 2023-04-26 19:47:29 +00:00 committed by Gerrit Code Review
parent 4351fa6442
commit d5d91caa90
1 changed files with 39 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
ee02b88109a97e672797bbe3640e59690b135099 Normal file
View File

@ -0,0 +1,39 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "df4bd959_34b919a6",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 10342
},
"writtenOn": "2023-04-26T19:47:29Z",
"side": 1,
"message": "Other than the issue which was ID\u0027d by zuul; this LGTM",
"revId": "ee02b88109a97e672797bbe3640e59690b135099",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "8b5e3b43_fd4a048a",
"filename": "ironic_python_agent/hardware_managers/nvidia/nvidia_fw_update.py",
"patchSetId": 1
},
"lineNbr": 421,
"author": {
"id": 10342
},
"writtenOn": "2023-04-26T19:47:29Z",
"side": 1,
"message": "\u003e pep8: F821 undefined name \u0027CONF\u0027\n\nPlease fix.",
"parentUuid": "8a0f915c_666c51ef",
"revId": "ee02b88109a97e672797bbe3640e59690b135099",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}