From d8a12531bfb4e5b51843819f95f76a656d5ba9b0 Mon Sep 17 00:00:00 2001 From: ghanshyam Date: Wed, 9 May 2018 02:15:31 +0000 Subject: [PATCH] Gate fix: Cap hacking to avoid gate failure hacking is not capped in g-r and it is in blacklist for requirement as hacking new version can break the gate jobs. Hacking can break gate jobs because of various reasons: - There might be new rule addition in hacking - Some rules becomes default from non-default - Updates in pycodestyle etc That was the main reason it was not added in g-r auto sync also. Most of the project maintained the compatible and cap the hacking version in test-requirements.txt and update to new version when project is ready. Bumping new version might need code fix also on project side depends on what new in that version. If project does not have cap the hacking version then, there is possibility of gate failure whenever new hacking version is released by QA team. Example of such failure in recent release of hacking 1.1.0 - http://lists.openstack.org/pipermail/openstack-dev/2018-May/130282.html Also includes commit c09634ad80988e960af2bcaca737be3e87ba7592 from master to ignore W503, otherwise the CI does not pass. Change-Id: I2c84d3368bd6675c28ebba695e0c1afdd2867588 (cherry picked from commit a69ccee2879abe3ac658f3fcbb564b254d84803d) (cherry picked from commit c09634ad80988e960af2bcaca737be3e87ba7592) --- test-requirements.txt | 2 +- tox.ini | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/test-requirements.txt b/test-requirements.txt index 2b4c677ea..c67ae7df4 100644 --- a/test-requirements.txt +++ b/test-requirements.txt @@ -1,7 +1,7 @@ # The order of packages is significant, because pip processes them in the order # of appearance. Changing the order has an impact on the overall integration # process, which may cause wedges in the gate later. -hacking>=1.0.0 # Apache-2.0 +hacking>=1.0.0,<1.1.0 # Apache-2.0 coverage!=4.4,>=4.0 # Apache-2.0 mock>=2.0.0 # BSD testtools>=2.2.0 # MIT diff --git a/tox.ini b/tox.ini index bb25f17d9..2b66107db 100644 --- a/tox.ini +++ b/tox.ini @@ -68,7 +68,9 @@ commands = commands = sphinx-build -a -E -W -d releasenotes/build/doctrees -b html releasenotes/source releasenotes/build/html [flake8] -ignore = E129 +# [E129] visually indented line with same indent as next logical line. +# [W503] Line break before binary operator. +ignore = E129,W503 exclude = .venv,.git,.tox,dist,doc,*lib/python*,*egg,build,tools,imagebuild/tinyipa/tinyipafinal,imagebuild/tinyipa/tinyipabuild import-order-style = pep8 application-import-names = ironic_python_agent