openstack
/
ironic-python-agent
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review+2 Workflow+1

(4 comments)

Patch-set: 1
Reviewer: Gerrit User 23851 <23851@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2, d1668375a70bd9c9cb51dfc217ecdb6e7a95b965
Label: Workflow=+1, f42d9285ebcabfe2633bba46712fbc99c8ca18cf
Attention: {"person_ident":"Gerrit User 23851 \u003c23851@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_23851\u003e replied on the change"}
This commit is contained in:
Gerrit User 23851 2024-04-27 15:40:15 +00:00 committed by Gerrit Code Review
parent db250e5bf5
commit f0a1a8959b
1 changed files with 68 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

68
84a1195d5ad9bdc1fbe30113989bc4cbb0699965
View File

@ -33,6 +33,74 @@
"message": "LGTM",
"revId": "84a1195d5ad9bdc1fbe30113989bc4cbb0699965",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "2dbcf118_ccf955c0",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 23851
},
"writtenOn": "2024-04-27T15:40:15Z",
"side": 1,
"message": "thanks!",
"revId": "84a1195d5ad9bdc1fbe30113989bc4cbb0699965",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b4a955cd_bf0e4208",
"filename": "ironic_python_agent/hardware.py",
"patchSetId": 1
},
"lineNbr": 488,
"author": {
"id": 23851
},
"writtenOn": "2024-04-27T15:40:15Z",
"side": 1,
"message": "nit: also",
"revId": "84a1195d5ad9bdc1fbe30113989bc4cbb0699965",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "70a20750_621decff",
"filename": "ironic_python_agent/hardware.py",
"patchSetId": 1
},
"lineNbr": 1627,
"author": {
"id": 23851
},
"writtenOn": "2024-04-27T15:40:15Z",
"side": 1,
"message": "nit: redundancy",
"revId": "84a1195d5ad9bdc1fbe30113989bc4cbb0699965",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "2c1521a0_5e4aa00e",
"filename": "ironic_python_agent/hardware.py",
"patchSetId": 1
},
"lineNbr": 1629,
"author": {
"id": 23851
},
"writtenOn": "2024-04-27T15:40:15Z",
"side": 1,
"message": "nit: unnecessary",
"revId": "84a1195d5ad9bdc1fbe30113989bc4cbb0699965",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}