openstack
/
ironic-python-agent
Code Issues Proposed changes

Update patch set 4 

Patch Set 4:

(1 comment)

Patch-set: 4
Attention: {"person_ident":"Gerrit User 10239 \u003c10239@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_11655\u003e replied on the change"}
This commit is contained in:
Gerrit User 11655 2023-04-17 16:56:36 +00:00 committed by Gerrit Code Review
parent f2a8776df4
commit f791d4dee4
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
30b360d5438b85d43356ede831284b33b9dd172b
View File

@ -17,6 +17,24 @@
"revId": "30b360d5438b85d43356ede831284b33b9dd172b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "f1489748_46464fdc",
"filename": "ironic_python_agent/netutils.py",
"patchSetId": 4
},
"lineNbr": 215,
"author": {
"id": 11655
},
"writtenOn": "2023-04-17T16:56:36Z",
"side": 1,
"message": "Interesting! Gerrit didn\u0027t show me this comment a half hour ago! Anyhow, I\u0027ve replied a little further below as to a conundrum which likely needs to be evaluated, although it was a conundrum with netifaces anyway, we should be defensive with the data we get and return.",
"parentUuid": "8d8fbb18_e3c90fb0",
"revId": "30b360d5438b85d43356ede831284b33b9dd172b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {