ironic-python-agent/releasenotes/notes/prevent-needless-iscsi-cleanup-f8d602c0abc7e8ba.yaml
Julia Kreger 2a56ee03b6 Prevent un-needed iscsi cleanup
When we added software raid support, we started calling bootloader
installation. As time went on, we ehnanced that code path for non
RAID cases in order to ensure that UEFI nvram was setup
for the instance to boot properly.

Somewhere in this process, we missed a possible failure case where
the iscsi client tgtadm may return failures. Obviously, the correct
path is to not call iscsi teardown if we don't need to.

Since it was always semi-opportunistic teardown, we can't blindly
catch any error, and if we started iSCSI and failed to tear the
connection down, we might want to still fail, so this change
moves the logic over to use a flag on the agent object which
one extension to set the flag and the other to read it and take
action based upon that.

Change-Id: Id3b1ae5e59282f4109f6246d5614d44c93aefa7c
Story: 2007937
Task: 40395
2020-07-20 14:24:06 -07:00

10 lines
462 B
YAML

---
fixes:
- |
Fixes an issue with the ironic-python-agent where we would call to
setup the bootloader, which is necessary with software raid, but also
attempt to clean up iSCSI. This can cause issues when using the ``direct``
``deploy_interface``. Now the agent will only clean up iSCSI connections
if iSCSI was explicitly started. For more information, please see
`story 2007937 <https://storyboard.openstack.org/#!/story/2007937>`_.