f1dec5c2e2
Some of the extensions in IPA currently do not return any values from their respective command methods. This results in a lack of a paper trail of the command_result value to the point where it is not possible to know more information than a boolean result of if a command succeeded or failed. This change adds more logging to the extensions and provides return values which are used in the command_result property on (Async|Sync)CommandResult instances to provide useful debug info. While creating this patch several unit tests for *CommandResult objects were found to be using invalid data that would not pass validation if returned in API results. Those have been corrected in this patch. Change-Id: I23bae25a83881e7013c93d73f858c622ea941253 Closes-Bug: 1408080
35 lines
1.3 KiB
Python
35 lines
1.3 KiB
Python
# Copyright 2013 Rackspace, Inc.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
import mock
|
|
from oslotest import base as test_base
|
|
|
|
from ironic_python_agent.extensions import decom
|
|
|
|
|
|
class TestDecomExtension(test_base.BaseTestCase):
|
|
def setUp(self):
|
|
super(TestDecomExtension, self).setUp()
|
|
self.agent_extension = decom.DecomExtension()
|
|
|
|
@mock.patch('ironic_python_agent.hardware.dispatch_to_managers',
|
|
autospec=True)
|
|
def test_erase_devices(self, mocked_dispatch):
|
|
result = self.agent_extension.erase_hardware()
|
|
result.join()
|
|
mocked_dispatch.assert_called_once_with('erase_devices')
|
|
self.assertTrue('result' in result.command_result.keys())
|
|
cmd_result_text = 'erase_hardware: finished'
|
|
self.assertEqual(cmd_result_text, result.command_result['result'])
|