91 lines
3.0 KiB
Plaintext
91 lines
3.0 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "867ee9d9_da0356a9",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 10342
|
|
},
|
|
"writtenOn": "2023-04-19T18:38:09Z",
|
|
"side": 1,
|
|
"message": "LGTM outside of the one question. Should we get Ade Lee to review this, too?",
|
|
"revId": "a55f3b8e18f8ab7ae1d3f5e30aa33f7932f75d04",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "813ff698_edf39cef",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 10342
|
|
},
|
|
"writtenOn": "2023-04-19T19:21:45Z",
|
|
"side": 1,
|
|
"message": "Thanks for the explanation!",
|
|
"revId": "a55f3b8e18f8ab7ae1d3f5e30aa33f7932f75d04",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "82c7fe87_db8befad",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 11655
|
|
},
|
|
"writtenOn": "2023-04-19T19:33:41Z",
|
|
"side": 1,
|
|
"message": "oh, forgot one quesiton! W/R/T Ade lee, I don\u0027t think it is really needed, but I\u0027ll be happy to ping him if you want another set of eyes on it.",
|
|
"parentUuid": "813ff698_edf39cef",
|
|
"revId": "a55f3b8e18f8ab7ae1d3f5e30aa33f7932f75d04",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "47691ab2_68c64287",
|
|
"filename": "ironic_python_agent/extensions/standby.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 296,
|
|
"author": {
|
|
"id": 10342
|
|
},
|
|
"writtenOn": "2023-04-19T18:38:09Z",
|
|
"side": 1,
|
|
"message": "Is it intentional that this isn\u0027t adding usedforsecurity\u003dFalse? https://docs.python.org/3/library/hashlib.html#hashlib.new",
|
|
"revId": "a55f3b8e18f8ab7ae1d3f5e30aa33f7932f75d04",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "bc200afd_e5c72a3d",
|
|
"filename": "ironic_python_agent/extensions/standby.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 296,
|
|
"author": {
|
|
"id": 11655
|
|
},
|
|
"writtenOn": "2023-04-19T18:51:38Z",
|
|
"side": 1,
|
|
"message": "Yes, checksum is a security action in this context. The acceptable non-security use of the flag per docs is compression/de-duplication. In this case, we\u0027re validating the file is what we were told matches the checksum we were told. I consulted glance, and the only place where they use it is for test value generation for unit testing.",
|
|
"parentUuid": "47691ab2_68c64287",
|
|
"revId": "a55f3b8e18f8ab7ae1d3f5e30aa33f7932f75d04",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |