ironic-python-agent/7e087f7c25442472dad3b854fb98310a5cfca6d8

{
  "comments": [
    {
      "unresolved": true,
      "key": {
        "uuid": "9113a9d4_790dfe50",
        "filename": "ironic_python_agent/efi_utils.py",
        "patchSetId": 3
      },
      "lineNbr": 326,
      "author": {
        "id": 10239
      },
      "writtenOn": "2024-04-05T15:45:49Z",
      "side": 1,
      "message": "Do you want to make the search case-insensitive? shim can also be SHIM",
      "revId": "7e087f7c25442472dad3b854fb98310a5cfca6d8",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "65befa22_ae43489a",
        "filename": "ironic_python_agent/efi_utils.py",
        "patchSetId": 3
      },
      "lineNbr": 326,
      "author": {
        "id": 4571
      },
      "writtenOn": "2024-04-08T22:00:31Z",
      "side": 1,
      "message": "Done, in GenericHardwareManager.clean_uefi_nvram",
      "parentUuid": "9113a9d4_790dfe50",
      "revId": "7e087f7c25442472dad3b854fb98310a5cfca6d8",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "c06a5202_2f33de86",
        "filename": "ironic_python_agent/hardware.py",
        "patchSetId": 3
      },
      "lineNbr": 2428,
      "author": {
        "id": 10239
      },
      "writtenOn": "2024-04-05T15:45:49Z",
      "side": 1,
      "message": "A clean step as well for consistency?",
      "revId": "7e087f7c25442472dad3b854fb98310a5cfca6d8",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "4d496d5a_2b71a0de",
        "filename": "ironic_python_agent/hardware.py",
        "patchSetId": 3
      },
      "lineNbr": 2428,
      "author": {
        "id": 4571
      },
      "writtenOn": "2024-04-08T22:00:31Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "c06a5202_2f33de86",
      "revId": "7e087f7c25442472dad3b854fb98310a5cfca6d8",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "5e71383f_ca105b82",
        "filename": "ironic_python_agent/hardware.py",
        "patchSetId": 3
      },
      "lineNbr": 2571,
      "author": {
        "id": 10239
      },
      "writtenOn": "2024-04-05T15:45:49Z",
      "side": 1,
      "message": "OMG why is this a service step? O__o",
      "revId": "7e087f7c25442472dad3b854fb98310a5cfca6d8",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "0e49ccac_4ba48b69",
        "filename": "ironic_python_agent/hardware.py",
        "patchSetId": 3
      },
      "lineNbr": 2571,
      "author": {
        "id": 4571
      },
      "writtenOn": "2024-04-08T22:00:31Z",
      "side": 1,
      "message": "Lol, removed for now. But it could be a service step if the default match pattern is an empty list, making it a noop by default.",
      "parentUuid": "5e71383f_ca105b82",
      "revId": "7e087f7c25442472dad3b854fb98310a5cfca6d8",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "7d70f96d_bc2e5f74",
        "filename": "ironic_python_agent/hardware.py",
        "patchSetId": 3
      },
      "lineNbr": 2571,
      "author": {
        "id": 10239
      },
      "writtenOn": "2024-04-09T09:12:47Z",
      "side": 1,
      "message": "Sorry for confusing you, it was a side comment about write_image. But yes, thinking about it, clean_uefi_nvram is questionable as a service step - too easy to corrupt the deployment and also easy enough to do from within the machine.",
      "parentUuid": "0e49ccac_4ba48b69",
      "revId": "7e087f7c25442472dad3b854fb98310a5cfca6d8",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "319ec293_c6db35b2",
        "filename": "releasenotes/notes/clean_uefi_nvram-554041f2e7b2d555.yaml",
        "patchSetId": 3
      },
      "lineNbr": 6,
      "author": {
        "id": 10239
      },
      "writtenOn": "2024-04-05T15:45:49Z",
      "side": 1,
      "message": "typo: shim",
      "revId": "7e087f7c25442472dad3b854fb98310a5cfca6d8",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "e782368b_883b8e8e",
        "filename": "releasenotes/notes/clean_uefi_nvram-554041f2e7b2d555.yaml",
        "patchSetId": 3
      },
      "lineNbr": 6,
      "author": {
        "id": 4571
      },
      "writtenOn": "2024-04-08T22:00:31Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "319ec293_c6db35b2",
      "revId": "7e087f7c25442472dad3b854fb98310a5cfca6d8",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    }
  ]
}