openstack
/
ironic-specs
Code Issues Proposed changes

Add a section for RPC API impact 

Changes to the RPC API should definitely be considered.

This changes the unit test to verify specs for Kilo only
since we shouldn't hold past accepted specs to new template
changes.

Change-Id: I3f8857f92ae80cfef01fb4a88e8bdb6a1add1905
This commit is contained in:
David Shrewsbury 2014-06-27 15:38:58 -04:00
parent df1165677f
commit 7e9bf49da4
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
specs/template.rst
View File

@ -140,6 +140,15 @@ content of the JSON dict and an ability to validate it.
Reuse of existing predefined parameter types is highly encouraged.
RPC API impact
--------------
Changes which affect the RPC API should be listed here. For example:
* What are the changes, if any, to existing API calls?
* What new API calls are being added? Will these be using cast() or call()?
Driver API impact
-----------------

3
tests/test_titles.py
View File

@ -48,6 +48,7 @@ class TestTitles(testtools.TestCase):
self.assertIn('Alternatives', titles[proposed])
self.assertIn('Data model impact', titles[proposed])
self.assertIn('REST API impact', titles[proposed])
self.assertIn('RPC API impact', titles[proposed])
self.assertIn('Driver API impact', titles[proposed])
self.assertIn('Nova driver impact', titles[proposed])
self.assertIn('Security impact', titles[proposed])
@ -91,7 +92,7 @@ class TestTitles(testtools.TestCase):
(len(matches), tpl))
def test_template(self):
files = ['specs/template.rst'] + glob.glob('specs/*/*')
files = ['specs/template.rst'] + glob.glob('specs/kilo/*')
for filename in files:
self.assertTrue(filename.endswith(".rst"),
"spec's file must uses 'rst' extension.")