ironic-specs/tests/test_titles.py
Ruby Loo be2b71fe3b Support StoryBoard URLs
Now that ironic has moved from using Launchpad to Storyboard for
tracking features/RFEs, we need to check for StoryBoard URLs in
the specifications.

Co-Authored-By: Julia Kreger <juliaashleykreger@gmail.com>
Change-Id: I3442f653a2dc610213d34b55ab8a4c466c888615
2018-04-02 10:03:18 -04:00

183 lines
6.5 KiB
Python

# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
import glob
import os.path
import re
import docutils.core
import testtools
CURRENT_DIR = 'approved'
FIRST_TITLE = 'Problem description'
DRAFT_DIR = 'backlog'
DRAFT_REQUIRED_TITLES = {
FIRST_TITLE: [],
'Proposed change': [],
}
# There has to be an RFE story in StoryBoard associated with this spec.
STORYBOARD_URL = 'https://storyboard.openstack.org/#!/story/'
# Backwards compatibility:
# There has to be an RFE bug in launchpad associated with this spec,
# and it could be in any ironic project (except for ironic-inspector
# which has its own specs repository), not just 'ironic'. However,
# checking for the presence of an ironic project in the URL isn't that
# useful since a valid bug URL might not have anything to do with ironic;
# e.g. https://bugs.launchpad.net/ironic/+bug/12345 :)
BUG_URL = 'https://bugs.launchpad.net/'
# Backwards compatibility:
BLUEPRINT_URL = 'https://blueprints.launchpad.net/ironic/+spec/'
class TestTitles(testtools.TestCase):
def _get_title(self, section_tree):
section = {
'subtitles': [],
}
for node in section_tree:
if node.tagname == 'title':
section['name'] = node.rawsource
elif node.tagname == 'section':
subsection = self._get_title(node)
section['subtitles'].append(subsection['name'])
return section
def _get_titles(self, spec):
titles = {}
for node in spec:
if node.tagname == 'section':
section = self._get_title(node)
titles[section['name']] = section['subtitles']
return titles
def _check_titles(self, filename, expect, allowed, actual):
missing_sections = set(expect) - set(actual)
extra_sections = set(actual) - set(expect).union(allowed)
msgs = []
if len(missing_sections) > 0:
msgs.append("Missing sections: %s" % missing_sections)
if len(extra_sections) > 0:
msgs.append("Extra sections: %s" % extra_sections)
for section in expect.keys():
# Sections missing entirely are already covered above
if section not in actual:
continue
missing_subsections = [x for x in expect[section]
if x not in actual[section]]
# extra subsections are allowed
if len(missing_subsections) > 0:
msgs.append("Section '%s' is missing subsections: %s"
% (section, missing_subsections))
if len(msgs) > 0:
self.fail("While checking '%s':\n %s"
% (filename, "\n ".join(msgs)))
def _check_file_ext(self, filename):
self.assertTrue(filename.endswith(".rst"),
"%s spec's file must uses 'rst' extension." % filename)
def _check_lp_link(self, filename, raw):
"""Check that the a link to Launchpad is present.
Checks that the URL for the bug or the blueprint is mentioned,
and that the filename matches the name of the blueprint.
This assumes that the bug or the blueprint URL occurs on a line
without any other text and the URL occurs before the first section
(title) of the specification.
param filename: path/name of the file
param raw: the data in the file
"""
(root, _) = os.path.splitext(os.path.basename(filename))
for i, line in enumerate(raw.split("\n")):
if STORYBOARD_URL in line:
return
# Backward compatibility
if BUG_URL in line:
return
if BLUEPRINT_URL in line:
self.assertTrue(line.endswith(root),
"Filename '%s' must match blueprint name '%s'" %
(filename, line))
return
if line.startswith(FIRST_TITLE):
break
self.fail("URL of associated story in Storyboard is missing")
def _check_license(self, raw):
# Check for the presence of this license string somewhere within the
# header of the spec file, ignoring newlines and blank lines and any
# other lines before or after it.
license_check_str = (
" This work is licensed under a Creative Commons Attribution 3.0"
" Unported License."
" http://creativecommons.org/licenses/by/3.0/legalcode")
header_check = ""
for i, line in enumerate(raw.split("\n")):
if line.startswith('='):
break
header_check = header_check + line
self.assertTrue(license_check_str in header_check)
def _get_spec_titles(self, filename):
with open(filename) as f:
data = f.read()
spec = docutils.core.publish_doctree(data)
titles = self._get_titles(spec)
return (data, titles)
def _get_template_titles(self):
with open("specs/template.rst") as f:
template = f.read()
spec = docutils.core.publish_doctree(template)
template_titles = self._get_titles(spec)
return template_titles
def test_current_cycle_template(self):
template_titles = self._get_template_titles()
files = glob.glob('specs/%s/*' % CURRENT_DIR)
for filename in files:
self._check_file_ext(filename)
(data, titles) = self._get_spec_titles(filename)
self._check_titles(filename, template_titles, {}, titles)
self._check_license(data)
self._check_lp_link(filename, data)
def test_backlog(self):
template_titles = self._get_template_titles()
files = glob.glob('specs/%s/*' % DRAFT_DIR)
for filename in files:
self._check_file_ext(filename)
(data, titles) = self._get_spec_titles(filename)
self._check_titles(filename, DRAFT_REQUIRED_TITLES,
template_titles, titles)
self._check_lp_link(filename, data)