openstack/ironic-tempest-plugin
Code Issues Proposed changes

Update patch set 8

Browse Source 
Patch Set 8: Code-Review-1

(4 comments)

Patch-set: 8
Reviewer: Gerrit User 11655 <11655@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 9359ba4fe7684433233d5df0e8e86fb1bcd83b4c
This commit is contained in:
Gerrit User 11655 2024-03-29 19:53:50 +00:00 committed by Gerrit Code Review
parent b5e9cf5f8a
commit d9a17ef397
1 changed files with 90 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

90
96117c9d97e6411403237cb0b1ca6bd004320881 Normal file
View File

@ -0,0 +1,90 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "63dba44a_0376b840",
"filename": "ironic_tempest_plugin/tests/api/admin/test_deploy_templates.py",
"patchSetId": 8
},
"lineNbr": 208,
"author": {
"id": 11655
},
"writtenOn": "2024-03-29T19:53:50Z",
"side": 1,
"message": "This class name is wrong, it should be the class name on line 199.\n\nYour saying \"call setUp method on the class my class is derived from, and as such you can\u0027t invoke something not inside of your current class\u0027s context.",
"range": {
"startLine": 208,
"startChar": 14,
"endLine": 208,
"endChar": 33
},
"revId": "96117c9d97e6411403237cb0b1ca6bd004320881",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e665e073_2fd8b614",
"filename": "ironic_tempest_plugin/tests/api/admin/test_deploy_templates.py",
"patchSetId": 8
},
"lineNbr": 243,
"author": {
"id": 11655
},
"writtenOn": "2024-03-29T19:53:50Z",
"side": 1,
"message": "This also needs to be changed to match line 234",
"range": {
"startLine": 243,
"startChar": 14,
"endLine": 243,
"endChar": 33
},
"revId": "96117c9d97e6411403237cb0b1ca6bd004320881",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "5719ae38_1798fe8b",
"filename": "ironic_tempest_plugin/tests/api/admin/test_nodes.py",
"patchSetId": 8
},
"lineNbr": 192,
"author": {
"id": 11655
},
"writtenOn": "2024-03-29T19:53:50Z",
"side": 1,
"message": "The class name here is wrong, it should be the class name on line 183.",
"revId": "96117c9d97e6411403237cb0b1ca6bd004320881",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "2e04a6e9_98ea0c22",
"filename": "ironic_tempest_plugin/tests/api/admin/test_nodes.py",
"patchSetId": 8
},
"lineNbr": 243,
"author": {
"id": 11655
},
"writtenOn": "2024-03-29T19:53:50Z",
"side": 1,
"message": "This is the wrong class name, should be TestNodesWithoutJsonExtSupport",
"range": {
"startLine": 243,
"startChar": 14,
"endLine": 243,
"endChar": 23
},
"revId": "96117c9d97e6411403237cb0b1ca6bd004320881",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}