7892692246
Patch Set 1: Code-Review-1 (1 comment) Patch-set: 1 Reviewer: Gerrit User 11655 <11655@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1, 900d253773e1cd206849fee8e22a8e2b1db03bb4
27 lines
1.2 KiB
Plaintext
27 lines
1.2 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "78dc7dfb_f72f6930",
|
|
"filename": "ironic_tempest_plugin/tests/scenario/ironic_standalone/test_advanced_ops.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 107,
|
|
"author": {
|
|
"id": 11655
|
|
},
|
|
"writtenOn": "2023-10-11T20:28:27Z",
|
|
"side": 1,
|
|
"message": "So what we need to do here is include a config_drive, specifically to hold the network data to be expanded upon.\n\nget_node_network_data in ironic\u0027s networking common has the pattern required:\n\nbasically:\n\nget vif, extract the port data, into appropriate fields, see ironic\u0027s get_neutron_port_data method, and send that along. At this level, config drive *likely* just needs to be an option, because the method below this either needs a vif, or we need to generate/attach the vif, and then do the needful.\n\nOnly with the vif, can we realistically generate a config drive entry.",
|
|
"range": {
|
|
"startLine": 107,
|
|
"startChar": 8,
|
|
"endLine": 107,
|
|
"endChar": 32
|
|
},
|
|
"revId": "d5d6931335ca635933914e6e3a2c1c91fb8511f3",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |