From 26cf25d98a1495d0db4a236bfaa6a0dbac7b9e37 Mon Sep 17 00:00:00 2001 From: Iury Gregory Melo Ferreira Date: Tue, 1 Jun 2021 11:20:15 +0200 Subject: [PATCH] Follow-up to Include bios registry fields in bios API This commit is a follow-up to Ie86ec57e428e2bb2efd099a839105e51a94824ab Story: #2008571 Task: #42546 Change-Id: I6fa4658180772ff9c4ff00f95b28cf8a1b5d4223 --- api-ref/source/baremetal-api-v1-nodes-bios.inc | 2 +- ironic/objects/bios.py | 2 +- .../notes/bios-registry-support-e7fd62908e9c222d.yaml | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/api-ref/source/baremetal-api-v1-nodes-bios.inc b/api-ref/source/baremetal-api-v1-nodes-bios.inc index 887e2029a9..c97026c155 100644 --- a/api-ref/source/baremetal-api-v1-nodes-bios.inc +++ b/api-ref/source/baremetal-api-v1-nodes-bios.inc @@ -111,7 +111,7 @@ Show single Bios setting of a Node Return the content of the specific bios ``bios_setting`` associated with ``node_ident``. -. versionadded:: 1.74 +.. versionadded:: 1.74 Introduced fields from the BIOS registry. Normal response code: 200 diff --git a/ironic/objects/bios.py b/ironic/objects/bios.py index cb6718074f..4462ca5266 100644 --- a/ironic/objects/bios.py +++ b/ironic/objects/bios.py @@ -155,7 +155,7 @@ class BIOSSetting(base.IronicObject): for field in self.get_registry_fields(): field_is_set = self.obj_attr_is_set(field) - if target_version >= (1, 74): + if target_version >= (1, 1): # target version supports the major/minor specified if not field_is_set: # set it to its default value if it is not set diff --git a/releasenotes/notes/bios-registry-support-e7fd62908e9c222d.yaml b/releasenotes/notes/bios-registry-support-e7fd62908e9c222d.yaml index adb49983ed..5db1d7605b 100644 --- a/releasenotes/notes/bios-registry-support-e7fd62908e9c222d.yaml +++ b/releasenotes/notes/bios-registry-support-e7fd62908e9c222d.yaml @@ -1,8 +1,8 @@ --- features: - | - Provide the registry fields in the BIOS setting API and in the BIOS setting - list when detail is requested. Also added fields selector to query API. + Provides the registry fields in the BIOS setting API and in the BIOS setting + list when detail is requested. Also adds fields selector to query API. See `story 2008571 `_.