openstack/ironic
Code Issues Proposed changes

Clean up eventlet monkey patch comment and reno

Browse Source 
This is a follow up to I887a06566dcc2f09875f975f1e12ae4ff75fd348.

The release note tense is fixed, and more information is added about why
the change was necessary.

Change-Id: Ie89e21460a4a7654795830bf4781404ec506a52f
This commit is contained in:
Mario Villaplana 2017-03-03 18:16:57 +00:00
parent 556b1d0871
commit 2751212eae
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ironic/cmd/__init__.py
View File

@ -13,8 +13,10 @@
# License for the specific language governing permissions and limitations # License for the specific language governing permissions and limitations
# under the License. # under the License.
# NOTE(yuriyz): Do eventlet monkey patching here, not in ironic/__init__.py # NOTE(yuriyz): Do eventlet monkey patching here, instead of in
# This allows API service runs under Apache. # ironic/__init__.py. This allows the API service to run without monkey
# patching under Apache (which uses its own concurrency model). Mixing
# concurrency models can cause undefined behavior and potentially API timeouts.
import os import os
os.environ['EVENTLET_NO_GREENDNS'] = 'yes' os.environ['EVENTLET_NO_GREENDNS'] = 'yes'

4
releasenotes/notes/apache-multiple-workers-11d4ba52c89a13e3.yaml
View File

@ -1,3 +1,5 @@
--- ---
fixes: fixes:
- Fix issue with multiple threads when ironic API service runs under Apache. - Fixes an issue with requests to the ironic API service sometimes timing
out when running under Apache. This was due to mixing two concurrency
models (for handling multiple threads).