openstack/ironic
Code Issues Proposed changes

Remove unused method is_valid_ipv6_cidr

Browse Source 
We don't use method is_valid_ipv6_cidr anywhere, so just remove it.

Change-Id: I855969e278533607508591421f175ec4662d0f45
This commit is contained in:
ChangBo Guo(gcb)
2016-09-26 14:42:17 +08:00
parent 659f951d72
commit 2db3e7dcd9
2 changed files with 0 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ironic/common/utils.py
View File

@@ -300,14 +300,6 @@ def validate_and_normalize_datapath_id(datapath_id):
return datapath_id.lower()
def is_valid_ipv6_cidr(address):
try:
str(netaddr.IPNetwork(address, version=6).cidr)
return True
except Exception:
return False
def get_shortened_ipv6(address):
addr = netaddr.IPAddress(address, version=6)
return str(addr.ipv6())

11
ironic/tests/unit/common/test_utils.py
View File

@@ -337,17 +337,6 @@ class GenericUtilsTestCase(base.TestCase):
self.assertFalse(utils.is_valid_boolstr('maybe'))
self.assertFalse(utils.is_valid_boolstr('only on tuesdays'))
def test_is_valid_ipv6_cidr(self):
self.assertTrue(utils.is_valid_ipv6_cidr("2600::/64"))
self.assertTrue(utils.is_valid_ipv6_cidr(
"abcd:ef01:2345:6789:abcd:ef01:192.168.254.254/48"))
self.assertTrue(utils.is_valid_ipv6_cidr(
"0000:0000:0000:0000:0000:0000:0000:0001/32"))
self.assertTrue(utils.is_valid_ipv6_cidr(
"0000:0000:0000:0000:0000:0000:0000:0001"))
self.assertFalse(utils.is_valid_ipv6_cidr("foo"))
self.assertFalse(utils.is_valid_ipv6_cidr("127.0.0.1"))
def test_get_shortened_ipv6(self):
self.assertEqual("abcd:ef01:2345:6789:abcd:ef01:c0a8:fefe",
utils.get_shortened_ipv6(