openstack
/
ironic
Code Issues Proposed changes

Enforce autospec in test_task_manager 

And remove corresponding filter from tox.ini

Change-Id: I226e329151e0f71e793ade432c80a1628aa21511
This commit is contained in:
Riccardo Pittau 2020-07-07 15:45:15 +02:00
parent f26b500efb
commit 359d6bca92
2 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
ironic/tests/unit/conductor/test_task_manager.py
View File

@ -35,14 +35,14 @@ from ironic.tests.unit.db import base as db_base
from ironic.tests.unit.objects import utils as obj_utils
@mock.patch.object(objects.Node, 'get')
@mock.patch.object(objects.Node, 'release')
@mock.patch.object(objects.Node, 'reserve')
@mock.patch.object(driver_factory, 'build_driver_for_task')
@mock.patch.object(objects.Port, 'list_by_node_id')
@mock.patch.object(objects.Portgroup, 'list_by_node_id')
@mock.patch.object(objects.VolumeConnector, 'list_by_node_id')
@mock.patch.object(objects.VolumeTarget, 'list_by_node_id')
@mock.patch.object(objects.Node, 'get', autospec=True)
@mock.patch.object(objects.Node, 'release', autospec=True)
@mock.patch.object(objects.Node, 'reserve', autospec=True)
@mock.patch.object(driver_factory, 'build_driver_for_task', autospec=True)
@mock.patch.object(objects.Port, 'list_by_node_id', autospec=True)
@mock.patch.object(objects.Portgroup, 'list_by_node_id', autospec=True)
@mock.patch.object(objects.VolumeConnector, 'list_by_node_id', autospec=True)
@mock.patch.object(objects.VolumeTarget, 'list_by_node_id', autospec=True)
class TaskManagerTestCase(db_base.DbTestCase):
def setUp(self):
super(TaskManagerTestCase, self).setUp()
@ -673,7 +673,7 @@ class TaskManagerTestCase(db_base.DbTestCase):
on_error_handler.assert_called_once_with(expected_exception,
'fake-argument')
@mock.patch.object(states.machine, 'copy')
@mock.patch.object(states.machine, 'copy', autospec=True)
def test_init_prepares_fsm(
self, copy_mock, get_volconn_mock, get_voltgt_mock,
get_portgroups_mock, get_ports_mock,

1
tox.ini
View File

@ -132,7 +132,6 @@ per-file-ignores =
ironic/tests/base.py:E402
ironic/tests/unit/api/*:H210
ironic/tests/unit/conductor/test_deployments.py:H210
ironic/tests/unit/conductor/test_task_manager.py:H210
ironic/tests/unit/conductor/test_notification_utils.py:H210
ironic/tests/unit/common/*:H210
ironic/tests/unit/drivers/modules/test_console_utils.py:H210