Merge "Sync boot mode when changing the boot device via Redfish" into stable/ussuri
This commit is contained in:
commit
46c6a4bf3d
|
@ -27,6 +27,7 @@ from ironic.common import indicator_states
|
|||
from ironic.common import utils
|
||||
from ironic.conductor import task_manager
|
||||
from ironic.drivers import base
|
||||
from ironic.drivers.modules import boot_mode_utils
|
||||
from ironic.drivers.modules.redfish import utils as redfish_utils
|
||||
|
||||
LOG = log.getLogger(__name__)
|
||||
|
@ -214,6 +215,10 @@ class RedfishManagement(base.ManagementInterface):
|
|||
LOG.error(error_msg)
|
||||
raise exception.RedfishError(error=error_msg)
|
||||
|
||||
# Ensure that boot mode is synced with what is set.
|
||||
# Some BMCs reset it to default (BIOS) when changing the boot device.
|
||||
boot_mode_utils.sync_boot_mode(task)
|
||||
|
||||
def get_boot_device(self, task):
|
||||
"""Get the current boot device for a node.
|
||||
|
||||
|
|
|
@ -96,9 +96,11 @@ class RedfishManagementTestCase(db_base.DbTestCase):
|
|||
task.driver.management.set_boot_device(task, target)
|
||||
|
||||
# Asserts
|
||||
fake_system.set_system_boot_options.assert_called_once_with(
|
||||
expected, enabled=sushy.BOOT_SOURCE_ENABLED_ONCE)
|
||||
mock_get_system.assert_called_once_with(task.node)
|
||||
fake_system.set_system_boot_options.assert_has_calls(
|
||||
[mock.call(expected,
|
||||
enabled=sushy.BOOT_SOURCE_ENABLED_ONCE),
|
||||
mock.call(mode=sushy.BOOT_SOURCE_MODE_BIOS)])
|
||||
mock_get_system.assert_called_with(task.node)
|
||||
self.assertNotIn('redfish_boot_device',
|
||||
task.node.driver_internal_info)
|
||||
|
||||
|
@ -121,9 +123,11 @@ class RedfishManagementTestCase(db_base.DbTestCase):
|
|||
task.driver.management.set_boot_device(
|
||||
task, boot_devices.PXE, persistent=target)
|
||||
|
||||
fake_system.set_system_boot_options.assert_called_once_with(
|
||||
sushy.BOOT_SOURCE_TARGET_PXE, enabled=expected)
|
||||
mock_get_system.assert_called_once_with(task.node)
|
||||
fake_system.set_system_boot_options.assert_has_calls(
|
||||
[mock.call(sushy.BOOT_SOURCE_TARGET_PXE,
|
||||
enabled=expected),
|
||||
mock.call(mode=sushy.BOOT_SOURCE_MODE_BIOS)])
|
||||
mock_get_system.assert_called_with(task.node)
|
||||
self.assertNotIn('redfish_boot_device',
|
||||
task.node.driver_internal_info)
|
||||
|
||||
|
@ -148,9 +152,10 @@ class RedfishManagementTestCase(db_base.DbTestCase):
|
|||
task.driver.management.set_boot_device(
|
||||
task, boot_devices.PXE, persistent=target)
|
||||
|
||||
fake_system.set_system_boot_options.assert_called_once_with(
|
||||
sushy.BOOT_SOURCE_TARGET_PXE, enabled=None)
|
||||
mock_get_system.assert_called_once_with(task.node)
|
||||
fake_system.set_system_boot_options.assert_has_calls(
|
||||
[mock.call(sushy.BOOT_SOURCE_TARGET_PXE, enabled=None),
|
||||
mock.call(mode=sushy.BOOT_SOURCE_MODE_BIOS)])
|
||||
mock_get_system.assert_called_with(task.node)
|
||||
|
||||
# Reset mocks
|
||||
fake_system.set_system_boot_options.reset_mock()
|
||||
|
@ -215,6 +220,7 @@ class RedfishManagementTestCase(db_base.DbTestCase):
|
|||
fake_system.set_system_boot_options.side_effect = [
|
||||
sushy.exceptions.SushyError(),
|
||||
None,
|
||||
None
|
||||
]
|
||||
mock_get_system.return_value = fake_system
|
||||
with task_manager.acquire(self.context, self.node.uuid,
|
||||
|
@ -225,9 +231,9 @@ class RedfishManagementTestCase(db_base.DbTestCase):
|
|||
mock.call(sushy.BOOT_SOURCE_TARGET_PXE,
|
||||
enabled=sushy.BOOT_SOURCE_ENABLED_CONTINUOUS),
|
||||
mock.call(sushy.BOOT_SOURCE_TARGET_PXE,
|
||||
enabled=sushy.BOOT_SOURCE_ENABLED_ONCE),
|
||||
enabled=sushy.BOOT_SOURCE_ENABLED_ONCE)
|
||||
])
|
||||
mock_get_system.assert_called_once_with(task.node)
|
||||
mock_get_system.assert_called_with(task.node)
|
||||
|
||||
task.node.refresh()
|
||||
self.assertEqual(
|
||||
|
|
|
@ -0,0 +1,8 @@
|
|||
---
|
||||
fixes:
|
||||
- |
|
||||
After changing the boot device via Redfish, check that the boot mode being
|
||||
reported matches what is configured and, if not, set it to the configured
|
||||
value. Some BMCs change the boot mode when the device is
|
||||
set via Redfish, see `story 2008252
|
||||
<https://storyboard.openstack.org/#!/story/2008252>`__ for details.
|
Loading…
Reference in New Issue