openstack/ironic
Code Issues Proposed changes

Stop unit-testing processutils internals

Browse Source 
Change-Id: Ia0c469669417f7de7b35ccf517750b9ecaebbed0
Closes-Bug: #1583535
This commit is contained in:
Dmitry Tantsur 2016-05-19 12:28:41 +02:00
parent 9739a22857
commit 4f463617ac
1 changed files with 0 additions and 54 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
ironic/tests/unit/drivers/modules/test_ssh.py
View File

@ -543,60 +543,6 @@ class SSHPrivateMethodsTestCase(db_base.DbTestCase):
get_hosts_name_mock.assert_called_once_with(self.sshclient, info) get_hosts_name_mock.assert_called_once_with(self.sshclient, info)
exec_ssh_mock.assert_called_once_with(self.sshclient, cmd_to_exec) exec_ssh_mock.assert_called_once_with(self.sshclient, cmd_to_exec)
def test_exec_ssh_command_good(self):
class Channel(object):
def recv_exit_status(self):
return 0
class Stream(object):
def __init__(self, buffer=''):
self.buffer = buffer
self.channel = Channel()
def read(self):
return self.buffer
def close(self):
pass
with mock.patch.object(self.sshclient, 'exec_command',
autospec=True) as exec_command_mock:
exec_command_mock.return_value = (Stream(),
Stream('hello'),
Stream())
stdout, stderr = processutils.ssh_execute(self.sshclient,
"command")
self.assertEqual('hello', stdout)
exec_command_mock.assert_called_once_with("command")
def test_exec_ssh_command_fail(self):
class Channel(object):
def recv_exit_status(self):
return 127
class Stream(object):
def __init__(self, buffer=''):
self.buffer = buffer
self.channel = Channel()
def read(self):
return self.buffer
def close(self):
pass
with mock.patch.object(self.sshclient, 'exec_command',
autospec=True) as exec_command_mock:
exec_command_mock.return_value = (Stream(),
Stream('hello'),
Stream())
self.assertRaises(processutils.ProcessExecutionError,
processutils.ssh_execute,
self.sshclient,
"command")
exec_command_mock.assert_called_once_with("command")
class SSHDriverTestCase(db_base.DbTestCase): class SSHDriverTestCase(db_base.DbTestCase):