openstack/ironic
Code Issues Proposed changes

Fix deprecated 'idrac' interface '__init__'s

Browse Source 
This change fixes the deprecated 'idrac' hardware interface
implementation '__init__' methods to call their base class '__init__'
methods before emitting a log message warning about their deprecation.

Story: 2008197
Task: 40977
Change-Id: Ic6e2b6744850d429fae2d353a91649ea68371a59
This commit is contained in:
Richard Pioso 2020-09-24 19:49:19 -04:00
parent 64085a29a2
commit 5ff3defb5c
6 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ironic/drivers/modules/drac/inspect.py
View File

@ -248,5 +248,6 @@ class DracInspect(DracWSManInspect):
"""
def __init__(self):
super(DracInspect, self).__init__()
LOG.warning("Inspect interface 'idrac' is deprecated and may be "
"removed in a future release. Use 'idrac-wsman' instead.")

3
ironic/drivers/modules/drac/management.py
View File

@ -2,7 +2,7 @@
#
# Copyright 2014 Red Hat, Inc.
# All Rights Reserved.
# Copyright (c) 2017-2019 Dell Inc. or its subsidiaries.
# Copyright (c) 2017-2020 Dell Inc. or its subsidiaries.
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
@ -478,5 +478,6 @@ class DracManagement(DracWSManManagement):
"""
def __init__(self):
super(DracManagement, self).__init__()
LOG.warning("Management interface 'idrac' is deprecated and may be "
"removed in a future release. Use 'idrac-wsman' instead.")

1
ironic/drivers/modules/drac/power.py
View File

@ -263,5 +263,6 @@ class DracPower(DracWSManPower):
"""
def __init__(self):
super(DracPower, self).__init__()
LOG.warning("Power interface 'idrac' is deprecated and may be removed "
"in a future release. Use 'idrac-wsman' instead.")

1
ironic/drivers/modules/drac/raid.py
View File

@ -1549,5 +1549,6 @@ class DracRAID(DracWSManRAID):
"""
def __init__(self):
super(DracRAID, self).__init__()
LOG.warning("RAID interface 'idrac' is deprecated and may be removed "
"in a future release. Use 'idrac-wsman' instead.")

1
ironic/drivers/modules/drac/vendor_passthru.py
View File

@ -186,6 +186,7 @@ class DracVendorPassthru(DracWSManVendorPassthru):
"""
def __init__(self):
super(DracVendorPassthru, self).__init__()
LOG.warning("Vendor passthru interface 'idrac' is deprecated and may "
"be removed in a future release. Use 'idrac-wsman' "
"instead.")

8
releasenotes/notes/idrac-fix-deprecated-idrac-interface-__init__-362696b389c86d5d.yaml Normal file
View File

@ -0,0 +1,8 @@
---
fixes:
- |
Fixes the deprecated ``idrac`` hardware interface implementation
``__init__`` methods to call their base class ``__init__`` methods before
emitting a log message warning about their deprecation. For more
information, see `story 2008197
<https://storyboard.openstack.org/#!/story/2008197>`_.