From 6e10ad9ad7548ca698055e882e3c45e5d962598c Mon Sep 17 00:00:00 2001
From: Dmitry Tantsur <dtantsur@protonmail.com>
Date: Tue, 28 Nov 2023 18:52:04 +0100
Subject: [PATCH] Add missing compatibility between idrac and redfish firmware

Change-Id: I3026a5c69930825ea2b88587e62b36e8824fa91e
---
 doc/source/admin/drivers/idrac.rst                      | 2 ++
 ironic/drivers/drac.py                                  | 5 +++++
 releasenotes/notes/idrac-firmware-3839648d729d9c7c.yaml | 5 +++++
 3 files changed, 12 insertions(+)
 create mode 100644 releasenotes/notes/idrac-firmware-3839648d729d9c7c.yaml

diff --git a/doc/source/admin/drivers/idrac.rst b/doc/source/admin/drivers/idrac.rst
index bd178a322c..fe1d615b05 100644
--- a/doc/source/admin/drivers/idrac.rst
+++ b/doc/source/admin/drivers/idrac.rst
@@ -87,6 +87,7 @@ following configuration:
     [DEFAULT]
     enabled_hardware_types=idrac
     enabled_bios_interfaces=idrac-redfish
+    enabled_firmware_interfaces=redfish
     enabled_inspect_interfaces=idrac-redfish
     enabled_management_interfaces=idrac-redfish
     enabled_power_interfaces=idrac-redfish
@@ -103,6 +104,7 @@ Interface            Supported Implementations
 ``boot``             ``ipxe``, ``pxe``, ``idrac-redfish-virtual-media``
 ``console``          ``no-console``
 ``deploy``           ``direct``, ``ansible``, ``ramdisk``
+``firmware``         ``redfish``, ``no-firmware``
 ``inspect``          ``idrac-wsman``, ``idrac``, ``idrac-redfish``,
                      ``inspector``, ``no-inspect``
 ``management``       ``idrac-wsman``, ``idrac``, ``idrac-redfish``
diff --git a/ironic/drivers/drac.py b/ironic/drivers/drac.py
index 266b21bee4..a4ca8004b3 100644
--- a/ironic/drivers/drac.py
+++ b/ironic/drivers/drac.py
@@ -28,6 +28,7 @@ from ironic.drivers.modules.drac import vendor_passthru
 from ironic.drivers.modules import ipxe
 from ironic.drivers.modules import noop
 from ironic.drivers.modules import pxe
+from ironic.drivers.modules.redfish import firmware as redfish_firmware
 
 
 CONF = cfg.CONF
@@ -61,6 +62,10 @@ class IDRACHardware(generic.GenericHardware):
         """List of supported bios interfaces."""
         return [bios.DracWSManBIOS, bios.DracRedfishBIOS, noop.NoBIOS]
 
+    @property
+    def supported_firmware_interfaces(self):
+        return [redfish_firmware.RedfishFirmware, noop.NoFirmware]
+
     @property
     def supported_inspect_interfaces(self):
         """List of supported inspect interfaces."""
diff --git a/releasenotes/notes/idrac-firmware-3839648d729d9c7c.yaml b/releasenotes/notes/idrac-firmware-3839648d729d9c7c.yaml
new file mode 100644
index 0000000000..d79f1126f2
--- /dev/null
+++ b/releasenotes/notes/idrac-firmware-3839648d729d9c7c.yaml
@@ -0,0 +1,5 @@
+---
+fixes:
+  - |
+    The ``idrac`` hardware type is now compatible with the ``redfish`` firmware
+    interface. The link between them was missing initially.