Suffix the ISO names with '.iso'

Some hardwares like ProLiant can validate the ISO images only if they are
suffixed with '.iso'. It is also recommended to suffix a particular file with
proper filename extension.

Change-Id: Ib754472e97006d0146dd0df99492b035c55a5c47
Story: #2008077
Task: #40768

ironic/drivers/modules/image_utils.py

@@ -192,7 +192,7 @@ def _get_iso_image_name(node):
 
     :param node: the node for which image name is to be provided.
     """
-    return "boot-%s" % node.uuid
+    return "boot-%s.iso" % node.uuid
 
 
 def cleanup_iso_image(task):

ironic/tests/unit/drivers/modules/test_image_utils.py

@@ -223,7 +223,7 @@ class RedfishImageUtilsTestCase(db_base.DbTestCase):
                                   shared=True) as task:
             image_utils.cleanup_iso_image(task)
 
-            object_name = 'boot-%s' % task.node.uuid
+            object_name = 'boot-%s.iso' % task.node.uuid
 
             mock_unpublish.assert_called_once_with(mock.ANY, object_name)
 
@@ -244,7 +244,7 @@ class RedfishImageUtilsTestCase(db_base.DbTestCase):
                 task, 'http://kernel/img', 'http://ramdisk/img',
                 'http://bootloader/img', root_uuid=task.node.uuid)
 
-            object_name = 'boot-%s' % task.node.uuid
+            object_name = 'boot-%s.iso' % task.node.uuid
 
             mock_publish_image.assert_called_once_with(
                 mock.ANY, mock.ANY, object_name)
@@ -275,7 +275,7 @@ class RedfishImageUtilsTestCase(db_base.DbTestCase):
                 task, 'http://kernel/img', 'http://ramdisk/img',
                 bootloader_href=None, root_uuid=task.node.uuid, base_iso=None)
 
-            object_name = 'boot-%s' % task.node.uuid
+            object_name = 'boot-%s.iso' % task.node.uuid
 
             mock_publish_image.assert_called_once_with(
                 mock.ANY, mock.ANY, object_name)

releasenotes/notes/add-iso-suffix-557a4fc4382fd7f3.yaml

@@ -0,0 +1,6 @@
+---
+fixes:
+  - |
+    Add the suffix ".iso" for the ISO images generated by Ironic, as some
+    hardwares can not load the ISO images if they are not suffixed with
+    ".iso". It is also recommended to name the files with proper extensions.