Browse Source

Remove default option from create iso image

THe -cache-inodes is already default on UNIX like operating systems and
it's not safe on other systems that do not have unique inode numbers.

Change-Id: I90b77b3a2056a7e627351d2d9e824def868a7b8b
changes/74/818874/3
Riccardo Pittau 2 months ago
parent
commit
7ca27601d6
  1. 2
      ironic/common/images.py
  2. 2
      ironic/tests/unit/common/test_images.py

2
ironic/common/images.py

@ -239,7 +239,7 @@ def create_isolinux_image_for_bios(
try:
utils.execute('mkisofs', '-r', '-V', _label(files_info),
'-cache-inodes', '-J', '-l', '-no-emul-boot',
'-J', '-l', '-no-emul-boot',
'-boot-load-size', '4', '-boot-info-table',
'-b', ISOLINUX_BIN, '-o', output_file, tmpdir)
except processutils.ProcessExecutionError as e:

2
ironic/tests/unit/common/test_images.py

@ -638,7 +638,7 @@ class FsImageTestCase(base.TestCase):
write_to_file_mock.assert_called_once_with(cfg_file, cfg)
execute_mock.assert_called_once_with(
'mkisofs', '-r', '-V',
"VMEDIA_BOOT_ISO", '-cache-inodes', '-J', '-l',
"VMEDIA_BOOT_ISO", '-J', '-l',
'-no-emul-boot', '-boot-load-size',
'4', '-boot-info-table', '-b', 'isolinux/isolinux.bin',
'-o', 'tgt_file', 'tmpdir')

Loading…
Cancel
Save