From 7ca27601d628d51d111a9742c298386e188e42e7 Mon Sep 17 00:00:00 2001 From: Riccardo Pittau Date: Tue, 23 Nov 2021 10:31:18 +0100 Subject: [PATCH] Remove default option from create iso image THe -cache-inodes is already default on UNIX like operating systems and it's not safe on other systems that do not have unique inode numbers. Change-Id: I90b77b3a2056a7e627351d2d9e824def868a7b8b --- ironic/common/images.py | 2 +- ironic/tests/unit/common/test_images.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ironic/common/images.py b/ironic/common/images.py index d2eb0d76ee..0f83b8726e 100644 --- a/ironic/common/images.py +++ b/ironic/common/images.py @@ -239,7 +239,7 @@ def create_isolinux_image_for_bios( try: utils.execute('mkisofs', '-r', '-V', _label(files_info), - '-cache-inodes', '-J', '-l', '-no-emul-boot', + '-J', '-l', '-no-emul-boot', '-boot-load-size', '4', '-boot-info-table', '-b', ISOLINUX_BIN, '-o', output_file, tmpdir) except processutils.ProcessExecutionError as e: diff --git a/ironic/tests/unit/common/test_images.py b/ironic/tests/unit/common/test_images.py index 2f9875f469..14017682bc 100644 --- a/ironic/tests/unit/common/test_images.py +++ b/ironic/tests/unit/common/test_images.py @@ -638,7 +638,7 @@ class FsImageTestCase(base.TestCase): write_to_file_mock.assert_called_once_with(cfg_file, cfg) execute_mock.assert_called_once_with( 'mkisofs', '-r', '-V', - "VMEDIA_BOOT_ISO", '-cache-inodes', '-J', '-l', + "VMEDIA_BOOT_ISO", '-J', '-l', '-no-emul-boot', '-boot-load-size', '4', '-boot-info-table', '-b', 'isolinux/isolinux.bin', '-o', 'tgt_file', 'tmpdir')