openstack
/
ironic
Code Issues Proposed changes

Merge "[Trivial] Fix awkward mocking in redfish boot tests"

This commit is contained in:
Zuul 2020-05-18 09:23:58 +00:00 committed by Gerrit Code Review
parent 07e57d91e2 ccdd5e9776
commit 8849a2d370
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
ironic/tests/unit/drivers/modules/redfish/test_bios.py
View File

@ -93,14 +93,13 @@ class RedfishBiosTestCase(db_base.DbTestCase):
with task_manager.acquire(self.context, self.node.uuid,
shared=True) as task:
attributes = mock_get_system(task.node).bios.attributes
settings = [{'name': k, 'value': v} for k, v in attributes.items()]
mock_get_system.reset_mock()
settings = {'foo': 'bar'}
mock_get_system.return_value.bios.attributes = settings
task.driver.bios.cache_bios_settings(task)
mock_get_system.assert_called_once_with(task.node)
mock_setting_list.sync_node_setting.assert_called_once_with(
task.context, task.node.id, settings)
task.context, task.node.id, [{'name': 'foo', 'value': 'bar'}])
mock_setting_list.create.assert_not_called()
mock_setting_list.save.assert_not_called()
mock_setting_list.delete.assert_not_called()
@ -148,14 +147,13 @@ class RedfishBiosTestCase(db_base.DbTestCase):
with task_manager.acquire(self.context, self.node.uuid,
shared=True) as task:
attributes = mock_get_system(task.node).bios.attributes
settings = [{'name': k, 'value': v} for k, v in attributes.items()]
mock_get_system.reset_mock()
settings = {'foo': 'bar'}
mock_get_system.return_value.bios.attributes = settings
task.driver.bios.cache_bios_settings(task)
mock_get_system.assert_called_once_with(task.node)
mock_setting_list.sync_node_setting.assert_called_once_with(
task.context, task.node.id, settings)
task.context, task.node.id, [{'name': 'foo', 'value': 'bar'}])
mock_setting_list.create.assert_called_once_with(
task.context, task.node.id, create_list)
mock_setting_list.save.assert_called_once_with(