openstack/ironic
Code Issues Proposed changes

Log node UUID and not entire node instance to

Browse Source 
avoid logging its driver_info field

Change-Id: I07eed090920c777046fe29618d5d8be42618a0f6
This commit is contained in:
Mahnoor Asghar 2024-07-24 05:53:13 -04:00
parent acf1c7d43e
commit 88ad9a7bbf
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ironic/conductor/cleaning.py
View File

@ -54,7 +54,7 @@ def do_node_clean(task, clean_steps=None, disable_ramdisk=False):
how = ('API' if node.automated_clean is False else 'configuration') how = ('API' if node.automated_clean is False else 'configuration')
LOG.info('Automated cleaning is disabled via %(how)s, node %(node)s ' LOG.info('Automated cleaning is disabled via %(how)s, node %(node)s '
'has been successfully moved to AVAILABLE state', 'has been successfully moved to AVAILABLE state',
{'how': how, 'node': node}) {'how': how, 'node': node.uuid})
return return
# NOTE(dtantsur): this is only reachable during automated cleaning, # NOTE(dtantsur): this is only reachable during automated cleaning,

7
releasenotes/notes/remove-node-object-from-log-statement-f1b92a8ca26686c2.yaml Normal file
View File

@ -0,0 +1,7 @@
---
security:
- |
Log the node UUID instead of the full node object in
ironic/conductor/cleaning.py, to avoid logging the node's driver_info
property (containing its BMC username and password).