Using loop instead of with_X

The loop keyword is the current recommended way to handle loops,
and supports filters.
It's available since Ansible version 2.5 so changing ansible
requirement in driver-requirements.

Change-Id: Ibff1f07ca00b8f5a5274d73f9e53196f49c33a66
This commit is contained in:
Riccardo Pittau 2019-10-23 12:02:51 +02:00
parent 0f95848d6f
commit 89c30cb923
4 changed files with 8 additions and 3 deletions
doc/source/admin/drivers
driver-requirements.txt
ironic/drivers/modules/ansible/playbooks/roles/discover/tasks
releasenotes/notes

@ -125,7 +125,7 @@ Requirements
============ ============
Ansible Ansible
Tested with, and targets, Ansible 2.4.x Tested with, and targets, Ansible 2.5.x
Bootstrap image requirements Bootstrap image requirements
---------------------------- ----------------------------

@ -14,7 +14,7 @@ python-xclarityclient>=0.1.6
sushy>=2.0.0 sushy>=2.0.0
# Ansible-deploy interface # Ansible-deploy interface
ansible>=2.4 ansible>=2.5
# HUAWEI iBMC hardware type uses the python-ibmcclient library # HUAWEI iBMC hardware type uses the python-ibmcclient library
python-ibmcclient>=0.1.0 python-ibmcclient>=0.1.0

@ -3,7 +3,7 @@
- set_fact: - set_fact:
ironic_root_device: /dev/{{ item.key }} ironic_root_device: /dev/{{ item.key }}
with_dict: "{{ ansible_devices }}" loop: "{{ ansible_devices | dict2items | sort(attribute='key') }}"
when: when:
- ironic_root_device is undefined - ironic_root_device is undefined
- item.value.host - item.value.host

@ -0,0 +1,5 @@
---
upgrade:
- |
Changing minimum version of Ansible for use with the ``ansible``
``deploy_interface`` to version 2.5.