From 8bcee6e20656656963bb4e546e552aeeaee9be90 Mon Sep 17 00:00:00 2001 From: Yuriy Zveryanskyy Date: Thu, 8 Dec 2016 13:19:00 +0200 Subject: [PATCH] Fix default value of "ignore_req_list" config option If audit is enabled ironic API service does not start with default value (None) of "ignore_req_list" config option. This patch changes default value to empty string. Related modification added to ironic sample config. Closes-Bug: 1648387 Change-Id: Ifbbbed4012670b4b05fcf63e5586024f3c927875 --- etc/ironic/ironic.conf.sample | 2 +- ironic/conf/audit.py | 1 + releasenotes/notes/bug-1648387-92db52cbe007fabd.yaml | 4 ++++ 3 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 releasenotes/notes/bug-1648387-92db52cbe007fabd.yaml diff --git a/etc/ironic/ironic.conf.sample b/etc/ironic/ironic.conf.sample index 86cc062be7..ab0d663541 100644 --- a/etc/ironic/ironic.conf.sample +++ b/etc/ironic/ironic.conf.sample @@ -663,7 +663,7 @@ # be done on any GET or POST requests if this is set to # "GET,POST". It is used only when API audit is enabled. # (string value) -#ignore_req_list = +#ignore_req_list = [cimc] diff --git a/ironic/conf/audit.py b/ironic/conf/audit.py index 784e588362..d71b340f57 100644 --- a/ironic/conf/audit.py +++ b/ironic/conf/audit.py @@ -26,6 +26,7 @@ opts = [ 'Used only when API audit is enabled.')), cfg.StrOpt('ignore_req_list', + default='', help=_('Comma separated list of Ironic REST API HTTP methods ' 'to be ignored during audit logging. For example: ' 'auditing will not be done on any GET or POST ' diff --git a/releasenotes/notes/bug-1648387-92db52cbe007fabd.yaml b/releasenotes/notes/bug-1648387-92db52cbe007fabd.yaml new file mode 100644 index 0000000000..9d3ba1b1b2 --- /dev/null +++ b/releasenotes/notes/bug-1648387-92db52cbe007fabd.yaml @@ -0,0 +1,4 @@ +--- +fixes: + - Fixes the issue that API service does not start if audit is enabled with + default value of "ignore_req_list" config option.