openstack/ironic
Code Issues Proposed changes

Simplify hash ring tests

Browse Source 
Move use_groups to a class-level variable so we don't need to
re-implement setUp in the subclass.

Change-Id: Ia7e508899e0db47bf4800f8411e02ebd21c62ffd
This commit is contained in:
Jim Rollenhagen
2018-07-25 11:49:46 +00:00
committed by Julia Kreger
parent a58d7bb81a
commit 8c16723fca
1 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ironic/tests/unit/common/test_hash_ring.py
+5 -6
View File
@@ -26,10 +26,12 @@ CONF = cfg.CONF
class HashRingManagerTestCase(db_base.DbTestCase):
use_groups = False
def setUp(self):
super(HashRingManagerTestCase, self).setUp()
self.use_groups = False
self.ring_manager = hash_ring.HashRingManager(use_groups=False)
self.ring_manager = hash_ring.HashRingManager(
use_groups=self.use_groups)
def register_conductors(self):
c1 = self.dbapi.register_conductor({
@@ -111,10 +113,7 @@ class HashRingManagerTestCase(db_base.DbTestCase):
class HashRingManagerWithGroupsTestCase(HashRingManagerTestCase):
def setUp(self):
super(HashRingManagerWithGroupsTestCase, self).setUp()
self.ring_manager = hash_ring.HashRingManager(use_groups=True)
self.use_groups = True
use_groups = True
def test_hash_ring_manager_hardware_type_success(self):
self.register_conductors()