openstack/ironic
Code Issues Proposed changes

Remove gettext.install() for unit tests

Browse Source 
Having gettext.install() done in the unit tests was masking the lack
of importing the '_' function from ironic.common.i18n

Fix one error discovered by removing gettext.install()

Closes-bug: #1668789
Change-Id: Ie7a7b1073e8ab5aa1c6f3fbe9eab8beb1c5d44a4
This commit is contained in:
John L. Villalovos 2017-02-28 14:41:16 -08:00
parent 83ba0880bd
commit 8cfbe1bad9
2 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ironic/drivers/modules/oneview/deploy.py
View File

@ -23,7 +23,7 @@ import retrying
import six
from ironic.common import exception
from ironic.common.i18n import _LE, _LI, _LW
from ironic.common.i18n import _, _LE, _LI, _LW
from ironic.common import states
from ironic.conductor import utils as manager_utils
from ironic.conf import CONF

3
ironic/tests/unit/objects/test_objects.py
View File

@ -14,7 +14,6 @@
import contextlib
import datetime
import gettext
import iso8601
import mock
@ -28,8 +27,6 @@ from ironic.objects import base
from ironic.objects import fields
from ironic.tests import base as test_base
gettext.install('ironic')
@base.IronicObjectRegistry.register
class MyObj(base.IronicObject, object_base.VersionedObjectDictCompat):