openstack
/
ironic
Code Issues Proposed changes

Unneeded testing in DB migration of volume connector 

This removes some testing from the unit test for the DB migration
of the volume connector table, since it does not seem useful to have
(https://review.openstack.org/#/c/285218/42/ironic/tests/unit/db/sqlalchemy/test_migrations.py).

Change-Id: I2f94fc481be2db7b96431d9a1ae6d230dafbe9db
Partial-Bug: 1526231
This commit is contained in:
Ruby Loo 2016-12-01 17:56:51 +00:00
parent 07541047be
commit 9606ac9ee3
1 changed files with 0 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
ironic/tests/unit/db/sqlalchemy/test_migrations.py
View File

@ -572,19 +572,6 @@ class MigrationCheckersMixin(object):
self.assertIsInstance(connectors.c.extra.type, self.assertIsInstance(connectors.c.extra.type,
sqlalchemy.types.TEXT) sqlalchemy.types.TEXT)
typestring = 'a' * 32
connector_idstring = 'a' * 255
uuid = uuidutils.generate_uuid()
data = {'uuid': uuid, 'node_id': 1, 'type': typestring,
'connector_id': connector_idstring, 'extra': '{}'}
connectors.insert().execute(data)
connector = connectors.select(
connectors.c.uuid == uuid).execute().first()
self.assertEqual(typestring, connector['type'])
self.assertEqual(connector_idstring, connector['connector_id'])
self.assertEqual(1, connector['node_id'])
self.assertEqual('{}', connector['extra'])
def _check_1a59178ebdf6(self, engine, data): def _check_1a59178ebdf6(self, engine, data):
targets = db_utils.get_table(engine, 'volume_targets') targets = db_utils.get_table(engine, 'volume_targets')
col_names = [column.name for column in targets.c] col_names = [column.name for column in targets.c]