openstack
/
ironic
Code Issues Proposed changes

Fix for Unable to create RAID1 on Dell BOSS card 

This patch changes the RAID configuration schema so that 0 is allowed
for size_gb.  This allows passing 0 for the size, which the Dell Boot
Optimized Storage Solution (BOSS) requires.

Change-Id: I57cf290021e32809b248350688c3f83e7bbf7351
Task: #22082
Story: #2002536
Co-Authored-By: Digambar Patil <digambarpat@gmail.com>
Depends-On: Id149f6250318e6162a168d002671faa2b3a7989b
(cherry picked from commit 01a9016779)
This commit is contained in:
Christopher Dearborn 2018-06-12 16:08:54 -04:00 committed by Julia Kreger
parent 21b199b586
commit 9850a86485
4 changed files with 22 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ironic/drivers/raid_config_schema.json
View File

@ -15,8 +15,7 @@
"size_gb": {
"anyOf": [{
"type": "integer",
"minimum": 0,
"exclusiveMinimum": true
"minimum": 0
},
{
"type": "string",

6
ironic/tests/unit/common/test_raid.py
View File

@ -69,6 +69,12 @@ class ValidateRaidConfigurationTestCase(base.TestCase):
raid_config,
raid_config_schema=self.schema)
def test_validate_configuration_zero_size_gb(self):
raid_config = json.loads(raid_constants.RAID_CONFIG_ZERO_SIZE_GB)
raid.validate_configuration(raid_config,
raid_config_schema=self.schema)
def test_validate_configuration_max_size_gb(self):
raid_config = json.loads(raid_constants.RAID_CONFIG_MAX_SIZE_GB)
raid.validate_configuration(raid_config,

11
ironic/tests/unit/raid_constants.py
View File

@ -84,6 +84,17 @@ RAID_CONFIG_INVALID_SIZE_GB = '''
}
'''
RAID_CONFIG_ZERO_SIZE_GB = '''
{
"logical_disks": [
{
"raid_level": "1",
"size_gb": 0
}
]
}
'''
RAID_CONFIG_MAX_SIZE_GB = '''
{
"logical_disks": [

4
releasenotes/notes/raid-dell-boss-e9c5da9ddceedd67.yaml Normal file
View File

@ -0,0 +1,4 @@
---
fixes:
- Fixes support for RAID 1 creation on Dell Boot Optimized Storage Solution
(BOSS).